Commit 7d349b6
Bump SCCNonlinearSolve compat floor to 1.13 to fix downgrade precompile (#4657)
The downgrade CI lanes ("Downgrade / InterfaceI" and
"downgrade-sublibraries / ModelingToolkitBase") resolved
SCCNonlinearSolve v1.12.1, whose `iteratively_build_sols`
preallocated a `Vector{NonlinearSolution}` and stored a
`LinearSolution` from a linear SCC directly into it, throwing
MethodError: Cannot `convert` an object of type
SciMLBase.LinearSolution to SciMLBase.NonlinearSolution
during the `SCCNonlinearProblem` precompile workload
(src/precompile.jl), failing precompilation of ModelingToolkit and
its extensions.
The fix landed in SCCNonlinearSolve 1.13.0 (commit c5c8120 "fix vector-form
SCCNonlinearProblem with linear SCCs"), which converts a linear SCC's
`LinearSolution` into a stripped `NonlinearSolution` before storing it.
Raising the floor from 1.8.1 to 1.13 prevents the downgrade resolver from
selecting a pre-fix version. SCC 1.13's SciMLBase compat (2.153-3) remains
compatible with ModelingToolkitBase's SciMLBase 3.18 floor.
Verified locally on Julia 1.10: with the old floor (SCC 1.12.1 pinned)
ModelingToolkit precompile fails with the convert MethodError; with the
new floor (SCC 1.13.0) precompile succeeds cleanly.
Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent f1b3089 commit 7d349b6
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
168 | 168 | | |
169 | 169 | | |
170 | 170 | | |
171 | | - | |
| 171 | + | |
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
| |||
0 commit comments