Skip to content

Commit 7d349b6

Browse files
ChrisRackauckas-ClaudeChrisRackauckasclaude
authored
Bump SCCNonlinearSolve compat floor to 1.13 to fix downgrade precompile (#4657)
The downgrade CI lanes ("Downgrade / InterfaceI" and "downgrade-sublibraries / ModelingToolkitBase") resolved SCCNonlinearSolve v1.12.1, whose `iteratively_build_sols` preallocated a `Vector{NonlinearSolution}` and stored a `LinearSolution` from a linear SCC directly into it, throwing MethodError: Cannot `convert` an object of type SciMLBase.LinearSolution to SciMLBase.NonlinearSolution during the `SCCNonlinearProblem` precompile workload (src/precompile.jl), failing precompilation of ModelingToolkit and its extensions. The fix landed in SCCNonlinearSolve 1.13.0 (commit c5c8120 "fix vector-form SCCNonlinearProblem with linear SCCs"), which converts a linear SCC's `LinearSolution` into a stripped `NonlinearSolution` before storing it. Raising the floor from 1.8.1 to 1.13 prevents the downgrade resolver from selecting a pre-fix version. SCC 1.13's SciMLBase compat (2.153-3) remains compatible with ModelingToolkitBase's SciMLBase 3.18 floor. Verified locally on Julia 1.10: with the old floor (SCC 1.12.1 pinned) ModelingToolkit precompile fails with the convert MethodError; with the new floor (SCC 1.13.0) precompile succeeds cleanly. Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent f1b3089 commit 7d349b6

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ PrecompileTools = "1.2.1"
109109
REPL = "1"
110110
Reexport = "0.2, 1"
111111
RuntimeGeneratedFunctions = "0.5.12"
112-
SCCNonlinearSolve = "1.8.1"
112+
SCCNonlinearSolve = "1.13"
113113
SciMLBase = "3"
114114
SciMLPublic = "1.0.0"
115115
Serialization = "1"

lib/ModelingToolkitBase/Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ RecursiveArrayTools = "3.26, 4"
168168
Reexport = "0.2, 1"
169169
ReferenceTests = "0.10"
170170
RuntimeGeneratedFunctions = "0.5.12"
171-
SCCNonlinearSolve = "1.8.1"
171+
SCCNonlinearSolve = "1.13"
172172
SafeTestsets = "0.1"
173173
SciMLBase = "3.18"
174174
SciMLPublic = "1.0.0"

0 commit comments

Comments
 (0)