test: restore working MTKBase BVP assertions (#4843)

Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com>

Author: ChrisRackauckas-Claude

lib/ModelingToolkitBase/test/bvproblem.jl

@@ -32,33 +32,21 @@ daesolvers = [Ascher2, Ascher4, Ascher6]
         lotkavolterra, [u0map; parammap], tspan
     )
 
-    if @isdefined(ModelingToolkit)
-        for solver in solvers
-            sol = solve(bvp, solver(), dt = 0.01)
-            @test isapprox(sol.u[end], osol.u[end]; atol = 0.01)
-            @test sol[[x, y], 1] == [1.0, 2.0]
-        end
-    else
-        for solver in solvers
-            @test_broken solve(bvp, solver(), dt = 0.01)
-        end
+    for solver in solvers
+        sol = solve(bvp, solver(), dt = 0.01)
+        @test isapprox(sol.u[end], osol.u[end]; atol = 0.01)
+        @test sol[[x, y], 1] == [1.0, 2.0]
     end
 
     # Test out of place
     bvp2 = SciMLBase.BVProblem{false, SciMLBase.AutoSpecialize}(
         lotkavolterra, [u0map; parammap], tspan
     )
 
-    if @isdefined(ModelingToolkit)
-        for solver in solvers
-            sol = solve(bvp2, solver(), dt = 0.01)
-            @test isapprox(sol.u[end], osol.u[end]; atol = 0.01)
-            @test sol[[x, y], 1] == [1.0, 2.0]
-        end
-    else
-        for solver in solvers
-            @test_broken solve(bvp2, solver(), dt = 0.01)
-        end
+    for solver in solvers
+        sol = solve(bvp2, solver(), dt = 0.01)
+        @test isapprox(sol.u[end], osol.u[end]; atol = 0.01)
+        @test sol[[x, y], 1] == [1.0, 2.0]
     end
 end
 
@@ -346,17 +334,13 @@ end
     @test_broken costfn(sol, prob.p, _t) ≈ (sol(0.6; idxs = x(t)) + 3)^2 + sol(0.3; idxs = x(t))^2
 
     bvp = SciMLBase.BVProblem{true, SciMLBase.AutoSpecialize}(lksys, [u0map; parammap], tspan)
-    if @isdefined(ModelingToolkit)
-        sol = solve(bvp, MIRK4(), dt = 0.05)
-        @test SciMLBase.successful_retcode(sol)
+    sol = solve(bvp, MIRK4(), dt = 0.05)
+    @test SciMLBase.successful_retcode(sol)
 
-        costfn = ModelingToolkitBase.generate_bvp_cost(
-            lksys; expression = Val{false}, wrap_gfw = Val{true}
-        )
-        @test costfn(sol, bvp.p) ≈ (sol(0.6; idxs = x(t)) + 3)^2 + sol(0.3; idxs = x(t))^2
-    else
-        @test_broken solve(bvp, MIRK4(), dt = 0.05)
-    end
+    costfn = ModelingToolkitBase.generate_bvp_cost(
+        lksys; expression = Val{false}, wrap_gfw = Val{true}
+    )
+    @test costfn(sol, bvp.p) ≈ (sol(0.6; idxs = x(t)) + 3)^2 + sol(0.3; idxs = x(t))^2
 
     ### With a parameter
     @parameters t_c
@@ -374,17 +358,13 @@ end
         log(sol(0.56; idxs = y(t)) + sol(0.0; idxs = x(t))) - sol(0.4; idxs = x(t))^2
 
     bvp = SciMLBase.BVProblem{true, SciMLBase.AutoSpecialize}(lksys, [u0map; parammap], tspan)
-    if @isdefined(ModelingToolkit)
-        sol = solve(bvp, MIRK4(), dt = 0.05)
-        @test SciMLBase.successful_retcode(sol)
+    sol = solve(bvp, MIRK4(), dt = 0.05)
+    @test SciMLBase.successful_retcode(sol)
 
-        costfn = ModelingToolkitBase.generate_bvp_cost(
-            lksys; expression = Val{false}, wrap_gfw = Val{true}
-        )
-        @test costfn(sol, bvp.p) ≈ log(sol(0.56; idxs = y(t)) + sol(0.0; idxs = x(t))) - sol(0.4; idxs = x(t))^2
-    else
-        @test_broken solve(bvp, MIRK4(), dt = 0.05)
-    end
+    costfn = ModelingToolkitBase.generate_bvp_cost(
+        lksys; expression = Val{false}, wrap_gfw = Val{true}
+    )
+    @test costfn(sol, bvp.p) ≈ log(sol(0.56; idxs = y(t)) + sol(0.0; idxs = x(t))) - sol(0.4; idxs = x(t))^2
 end
 
 @testset "Parameter estimation" begin