feat: compute jac_prototype for SDEFunction#3535
Merged
Merged
Conversation
Member
|
Can we make sure to add the mass matrix into the pattern? Because it will be a requirement of the future, so we should just make it robust now. |
Member
Author
|
Mass matrix is already in there |
Member
|
The mass matrix is a subset of |
Member
Author
|
No I mean it was there before, see lines 656-657 of the updated file |
Member
Author
|
@ChrisRackauckas @oscardssmith @AayushSabharwal
is this right? anything I'm missing? |
Member
Author
|
Nevermind this is writing to the wrong entries, need to investigate |
Member
|
So this is good to go? |
Member
Author
|
No I think it's still writing to the wrong entries sorry, investigating |
Member
Author
|
OK I think I fixed it, let's see how tests do. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #3527