fix: fix assert_jac_length_header#3556
Conversation
|
I can add something like the MWE in the issue as a test if we want, just not sure if exact numerical equality is something we (or SU) can guarantee in these cases. |
|
Let's add it as a test but put a comment to the PR and that it might be disabled in the future. Indeed, we cannot really guarantee that because LLVM could do optimizations that make it false, but at least for right now it seems like a good enough test. |
|
Just so I understand what's the change in the header here that makes it work with the CSE? Is it appending the assert to the end of the function? |
|
No. For CSE to work, it needs to get a symbolic expression. When you interpolate |
|
SymbolicIndexingInterface test group fails because SciMLBase needs a hotfix |
9b2bf45 to
be97e6b
Compare
be97e6b to
875837b
Compare
Close #3554