BVP cleanup#4405
Open
SebastianM-C wants to merge 2 commits intoSciML:masterfrom
Open
Conversation
The discrepancy between the interpolation methods is fixed by SciML/BoundaryValueDiffEq.jl#452
for the BVP case the solution is more precise at default tolerances
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in the BVP interpolation and I added some tests
that were using the internals of BVP solvers. That is no longer needed.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
See also SciML/BoundaryValueDiffEq.jl#452
The tests should pass once that merges (and it's released).