Skip to content

refactor: update to new SciMLBase remake API hooks with context structs #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AayushSabharwal merged 4 commits into from
Apr 28, 2026
Merged

refactor: update to new SciMLBase remake API hooks with context structs #4496

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18eb9a8
Accept ctx arg in late_binding_update_u0_p for SciMLBase v3.1.0+
ChrisRackauckas Apr 25, 2026
e02ead7
Apply suggestion from @ChrisRackauckas
ChrisRackauckas Apr 25, 2026
5ebbb6f
fix: `late_binding_update_u0_p` ctx should not be an optional argument
AayushSabharwal Apr 28, 2026
8910d01
refactor: update to new `remake_initialization_data` API
AayushSabharwal Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions lib/ModelingToolkitBase/src/systems/nonlinear/initializesystem.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,22 @@ function _has_delays(sys::AbstractSystem, ex, banned)
return any(x -> _has_delays(sys, x, banned), args)
end

function SciMLBase.remake_initialization_data(
@static if isdefined(SciMLBase, :RemakeInitializationDataContext)
function SciMLBase.remake_initialization_data(
sys::AbstractSystem, odefn, u0, t0, p, newu0, newp,
::SciMLBase.RemakeInitializationDataContext
)
_remake_initialization_data_impl(sys, odefn, u0, t0, p, newu0, newp)
end
else
function SciMLBase.remake_initialization_data(
sys::AbstractSystem, odefn, u0, t0, p, newu0, newp
)
_remake_initialization_data_impl(sys, odefn, u0, t0, p, newu0, newp)
end
end

function _remake_initialization_data_impl(
sys::AbstractSystem, odefn, u0, t0, p, newu0, newp
)
if u0 === missing && p === missing
Expand Down Expand Up @@ -688,7 +703,22 @@ function promote_u0_p(u0, p, t0)
return u0, p
end

function SciMLBase.late_binding_update_u0_p(
@static if isdefined(SciMLBase, :LateBindingUpdateU0PContext)
function SciMLBase.late_binding_update_u0_p(
prob, sys::AbstractSystem, u0, p, t0, newu0, newp,
ctx::SciMLBase.LateBindingUpdateU0PContext
)
return _late_binding_update_u0_p_impl(prob, sys, u0, p, t0, newu0, newp)
end
else
function SciMLBase.late_binding_update_u0_p(
prob, sys::AbstractSystem, u0, p, t0, newu0, newp
)
return _late_binding_update_u0_p_impl(prob, sys, u0, p, t0, newu0, newp)
end
end

function _late_binding_update_u0_p_impl(
prob, sys::AbstractSystem, u0, p, t0, newu0, newp
)
supports_initialization(sys) || return newu0, newp
Expand Down
Loading