fix: do not eliminate positive state priority variables in alias elimination#4497
Merged
Conversation
Member
|
what's special about positive state priority? |
Member
Author
|
Positive state priority means the user wants this variable to be part of the selected states, so we shouldn't eliminate it as observed. |
AayushSabharwal
force-pushed
the
as/alias-elim-irreducibles
branch
from
945c95c to
31e7e21
Compare
AayushSabharwal
force-pushed
the
as/alias-elim-irreducibles
branch
from
31e7e21 to
78a0948
Compare
oscardssmith
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes regressions in multibody models.