refactor: remove unnecessary reshape(view(...)) in codegen#4508
Merged
Conversation
We used to add all of them since this was cheaper than using `search_variables!` to identify the ones we need. With `IRStructure`, this is no longer the case. This reduces the size of the generated code, improves Julia compile time for the generated code, and slightly improves `ODEProblem` construction time for large models.
AayushSabharwal
force-pushed
the
as/rm-extra-reshape-view
branch
from
e2a07c8 to
1ac0700
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to add all of them since this was cheaper than using
search_variables!to identify the ones we need. WithIRStructure, this is no longer the case. This reduces the size of the generated code, improves Julia compile time for the generated code, and slightly improvesODEProblemconstruction time for large models.Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.