refactor: mark u argument in generated functions where appropriate#4536
Open
AayushSabharwal wants to merge 2 commits into
Open
refactor: mark u argument in generated functions where appropriate#4536AayushSabharwal wants to merge 2 commits into
u argument in generated functions where appropriate#4536AayushSabharwal wants to merge 2 commits into
Conversation
This allows marking the `u` argument of a generated function so it is specially named. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
So codegen should be able to refer to this for the vector of unknowns |
| since it is used by `wrap_delays`. | ||
| - `u_arg`: The index in `args` of the argument corresponding to `unknowns(sys)` (the `u` | ||
| vector). If `-1` (the default), the u vector is not treated specially. Otherwise, the | ||
| argument must be a `Vector` and is wrapped in a `DestructuredArgs` with the common |
Member
There was a problem hiding this comment.
Suggested change
| argument must be a `Vector` and is wrapped in a `DestructuredArgs` with the common | |
| argument must be an `AbstractVector` and is wrapped in a `DestructuredArgs` with the common |
Can we generalize? Otherwise GPUs and stuff may be sad.
Member
Author
There was a problem hiding this comment.
This is referring to a symbolic list of arguments, not the value passed to the generated function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows specialized codegen to refer to the
uvector.