Run Runic on master to fix the Runic Format Check#4647
Merged
AayushSabharwal merged 3 commits intoJun 22, 2026
Merged
Conversation
Member
|
Reran some jobs because I'm suspicious why they timed out |
The Runic Format Check on master is failing because 48 .jl files (mostly under lib/ModelingToolkitBase and lib/SciCompDSL, plus several root src/ and test/ files) drifted out of Runic format after recent merges. Format them with Runic v1.7.0 (the version the centralized SciML/.github runic.yml@v1 workflow resolves for runic-version=1). Pure formatting changes only (e.g. 1e-6 -> 1.0e-6, explicit trailing return, closing-paren line wrapping); no semantic changes. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The runic-action (Runic CLI) normalizes the file to a single trailing newline, which format_string does not do in-memory; src/systems/codegen.jl had an extra blank line at EOF that the CLI check flagged. Removing it makes the full-tree Runic CLI check pass (rc=0). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
AayushSabharwal
force-pushed
the
runic-format-master-d55a4aa
branch
from
517a54c to
72f44c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
masteris currently red on the Runic / Runic Format Check. 48 tracked.jlfiles (mostly underlib/ModelingToolkitBase/andlib/SciCompDSL/, plus several rootsrc/andtest/files) had drifted out of Runic format after recent merges.This PR reformats them with Runic v1.7.0 — the version the centralized
SciML/.github/.github/workflows/runic.yml@v1workflow resolves forrunic-version: "1".Verification
Ran Runic 1.7.0 locally over
git ls-files -- '*.jl':ALL CLEAN — Runic check passes(0 files flagged).Changes are purely stylistic (e.g.
1e-6->1.0e-6, explicit trailingreturn, closing-paren line wrapping); no semantic changes.Please ignore until reviewed by @ChrisRackauckas