Skip to content

refactor: update MTK to reversible transformations API#4659

Merged
AayushSabharwal merged 4 commits into
masterfrom
as/reversible-tfs-2
Jun 25, 2026
Merged

refactor: update MTK to reversible transformations API#4659
AayushSabharwal merged 4 commits into
masterfrom
as/reversible-tfs-2

Conversation

@AayushSabharwal

Copy link
Copy Markdown
Member

@AayushSabharwal AayushSabharwal changed the title As/reversible tfs 2 refactor: update MTK to reversible transformations API Jun 23, 2026
@AayushSabharwal AayushSabharwal marked this pull request as ready for review June 25, 2026 11:40
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia vlts)

Time benchmarks
master e7cb53d... master / e7cb53d...
ODEProblem 9.81 ± 0.21 ms 9.67 ± 0.12 ms 1.01 ± 0.025
init 0.0823 ± 0.024 ms 0.0861 ± 0.023 ms 0.956 ± 0.38
large_parameter_init/ODEProblem 0.0332 ± 0.0043 s 0.0318 ± 0.0043 s 1.05 ± 0.2
large_parameter_init/init 0.088 ± 0.022 ms 0.087 ± 0.02 ms 1.01 ± 0.35
mtkcompile 10.3 ± 0.27 ms 10.4 ± 0.5 ms 0.988 ± 0.054
sparse_analytical_jacobian/ODEProblem 28.7 ± 2.5 ms 28.5 ± 0.82 ms 1.01 ± 0.092
sparse_analytical_jacobian/f_iip 0.07 ± 0 μs 0.08 ± 0.009 μs 0.875 ± 0.098
sparse_analytical_jacobian/f_oop 0.38 ± 0.011 ms 0.381 ± 0.011 ms 0.998 ± 0.042
time_to_load 5.68 ± 0.1 s 5.7 ± 0.13 s 0.996 ± 0.029
Memory benchmarks
master e7cb53d... master / e7cb53d...
ODEProblem 0.0456 M allocs: 2.96 MB 0.0456 M allocs: 2.98 MB 0.995
init 0.418 k allocs: 0.0701 MB 0.418 k allocs: 0.0701 MB 1
large_parameter_init/ODEProblem 0.339 M allocs: 12.1 MB 0.339 M allocs: 12.1 MB 1
large_parameter_init/init 0.606 k allocs: 0.173 MB 0.606 k allocs: 0.173 MB 1
mtkcompile 0.0616 M allocs: 3.48 MB 0.0616 M allocs: 3.48 MB 1
sparse_analytical_jacobian/ODEProblem 0.208 M allocs: 8.55 MB 0.209 M allocs: 8.55 MB 1
sparse_analytical_jacobian/f_iip 0 allocs: 0 B 0 allocs: 0 B
sparse_analytical_jacobian/f_oop 0.634 k allocs: 19.6 kB 0.634 k allocs: 19.6 kB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master e7cb53d... master / e7cb53d...
ODEProblem 11.8 ± 0.63 ms 10.7 ± 0.42 ms 1.11 ± 0.074
init 0.045 ± 0.018 ms 0.0439 ± 0.017 ms 1.03 ± 0.58
large_parameter_init/ODEProblem 0.0353 ± 0.0062 s 0.0331 ± 0.0064 s 1.07 ± 0.28
large_parameter_init/init 0.0695 ± 0.036 ms 0.0706 ± 0.033 ms 0.986 ± 0.69
mtkcompile 10.2 ± 0.66 ms 8.85 ± 0.23 ms 1.15 ± 0.08
sparse_analytical_jacobian/ODEProblem 29.2 ± 3.5 ms 26.6 ± 3.6 ms 1.1 ± 0.2
sparse_analytical_jacobian/f_iip 0.09 ± 0.01 μs 0.081 ± 0.01 μs 1.11 ± 0.18
sparse_analytical_jacobian/f_oop 0.124 ± 0.013 ms 0.122 ± 0.014 ms 1.01 ± 0.16
time_to_load 5.67 ± 0.078 s 5.57 ± 0.012 s 1.02 ± 0.014
Memory benchmarks
master e7cb53d... master / e7cb53d...
ODEProblem 0.0502 M allocs: 2.95 MB 0.0502 M allocs: 2.97 MB 0.995
init 0.366 k allocs: 0.0457 MB 0.366 k allocs: 0.0457 MB 1
large_parameter_init/ODEProblem 0.352 M allocs: 13 MB 0.359 M allocs: 13.5 MB 0.968
large_parameter_init/init 0.8 k allocs: 0.152 MB 0.8 k allocs: 0.152 MB 1
mtkcompile 0.0563 M allocs: 2.76 MB 0.0563 M allocs: 2.76 MB 1
sparse_analytical_jacobian/ODEProblem 0.199 M allocs: 7.59 MB 0.199 M allocs: 7.59 MB 1
sparse_analytical_jacobian/f_iip 0 allocs: 0 B 0 allocs: 0 B
sparse_analytical_jacobian/f_oop 0.848 k allocs: 27 kB 0.848 k allocs: 27 kB 1
time_to_load 0.145 k allocs: 11 kB 0.145 k allocs: 11 kB 1

@AayushSabharwal

Copy link
Copy Markdown
Member Author

I messed up git stuff and lost the changes that would have fixed InterfaceI and should have been pushed. Will wait for CI to finish, then push the fix for InterfaceI and merge as soon as that test set passes.

@AayushSabharwal

Copy link
Copy Markdown
Member Author

InterfaceI is good now

@AayushSabharwal AayushSabharwal merged commit 3c42cc5 into master Jun 25, 2026
28 of 88 checks passed
@AayushSabharwal AayushSabharwal deleted the as/reversible-tfs-2 branch June 25, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant