Skip to content

refactor: eliminate unnecessary maxiters warnings if missing_guess_value is not Error#4674

Merged
AayushSabharwal merged 2 commits into
masterfrom
as/fewer-warnings
Jun 26, 2026
Merged

refactor: eliminate unnecessary maxiters warnings if missing_guess_value is not Error#4674
AayushSabharwal merged 2 commits into
masterfrom
as/fewer-warnings

Conversation

@AayushSabharwal

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia vlts)

Time benchmarks
master 72c5625... master / 72c5625...
ODEProblem 7.03 ± 3.8 ms 5.8 ± 0.54 ms 1.21 ± 0.67
init 0.0702 ± 0.027 ms 0.0671 ± 0.024 ms 1.05 ± 0.54
large_parameter_init/ODEProblem 0.0349 ± 0.0084 s 29.2 ± 5.3 ms 1.19 ± 0.36
large_parameter_init/init 0.0761 ± 0.021 ms 0.0685 ± 0.042 ms 1.11 ± 0.74
mtkcompile 11.3 ± 6.1 ms 8.42 ± 0.39 ms 1.35 ± 0.72
sparse_analytical_jacobian/ODEProblem 31 ± 7.7 ms 24.5 ± 3.3 ms 1.26 ± 0.36
sparse_analytical_jacobian/f_iip 0.08 ± 0.01 μs 0.06 ± 0 μs 1.33 ± 0.17
sparse_analytical_jacobian/f_oop 0.308 ± 0.013 ms 0.298 ± 0.0059 ms 1.03 ± 0.048
time_to_load 5.63 ± 0.38 s 5.1 ± 0.26 s 1.11 ± 0.094
Memory benchmarks
master 72c5625... master / 72c5625...
ODEProblem 0.0317 M allocs: 1.94 MB 0.0317 M allocs: 1.94 MB 1
init 0.418 k allocs: 0.0701 MB 0.418 k allocs: 0.0701 MB 1
large_parameter_init/ODEProblem 0.338 M allocs: 12.2 MB 0.338 M allocs: 12.2 MB 1
large_parameter_init/init 0.606 k allocs: 0.173 MB 0.606 k allocs: 0.173 MB 1
mtkcompile 0.0602 M allocs: 3.46 MB 0.0602 M allocs: 3.46 MB 1
sparse_analytical_jacobian/ODEProblem 0.207 M allocs: 8.58 MB 0.207 M allocs: 8.58 MB 1
sparse_analytical_jacobian/f_iip 0 allocs: 0 B 0 allocs: 0 B
sparse_analytical_jacobian/f_oop 0.634 k allocs: 19.6 kB 0.634 k allocs: 19.6 kB 1
time_to_load 0.153 k allocs: 14.6 kB 0.153 k allocs: 14.6 kB 1

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master 72c5625... master / 72c5625...
ODEProblem 11.9 ± 2.3 ms 8.63 ± 1.4 ms 1.38 ± 0.35
init 0.0784 ± 0.017 ms 0.0842 ± 0.055 ms 0.931 ± 0.64
large_parameter_init/ODEProblem 0.056 ± 0.006 s 0.0382 ± 0.008 s 1.47 ± 0.35
large_parameter_init/init 0.149 ± 0.067 ms 0.0854 ± 0.024 ms 1.75 ± 0.92
mtkcompile 12.7 ± 1.6 ms 10.3 ± 1.6 ms 1.23 ± 0.25
sparse_analytical_jacobian/ODEProblem 0.0393 ± 0.0056 s 0.0376 ± 0.0076 s 1.05 ± 0.26
sparse_analytical_jacobian/f_iip 0.09 ± 0 μs 0.08 ± 0.01 μs 1.12 ± 0.14
sparse_analytical_jacobian/f_oop 0.13 ± 0.019 ms 0.132 ± 0.015 ms 0.99 ± 0.18
time_to_load 9.31 ± 1.7 s 5.78 ± 0.13 s 1.61 ± 0.29
Memory benchmarks
master 72c5625... master / 72c5625...
ODEProblem 0.0371 M allocs: 2.11 MB 0.0371 M allocs: 2.08 MB 1.02
init 0.366 k allocs: 0.0457 MB 0.366 k allocs: 0.0457 MB 1
large_parameter_init/ODEProblem 0.358 M allocs: 13.2 MB 0.36 M allocs: 13.5 MB 0.982
large_parameter_init/init 0.8 k allocs: 0.152 MB 0.8 k allocs: 0.152 MB 1
mtkcompile 0.0563 M allocs: 2.76 MB 0.0563 M allocs: 2.76 MB 1
sparse_analytical_jacobian/ODEProblem 0.199 M allocs: 7.62 MB 0.199 M allocs: 7.63 MB 1
sparse_analytical_jacobian/f_iip 0 allocs: 0 B 0 allocs: 0 B
sparse_analytical_jacobian/f_oop 0.848 k allocs: 27 kB 0.848 k allocs: 27 kB 1
time_to_load 0.146 k allocs: 11.4 kB 0.146 k allocs: 11.4 kB 1

@AayushSabharwal AayushSabharwal merged commit f828027 into master Jun 26, 2026
70 of 89 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fewer-warnings branch June 26, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant