Skip to content

test: make inline linear SCC test more reliable#4695

Merged
AayushSabharwal merged 2 commits into
masterfrom
as/fix-ci
Jul 1, 2026
Merged

test: make inline linear SCC test more reliable#4695
AayushSabharwal merged 2 commits into
masterfrom
as/fix-ci

Conversation

@AayushSabharwal

Copy link
Copy Markdown
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia vlts)

Time benchmarks
master 3cc7857... master / 3cc7857...
ODEProblem 7.02 ± 0.29 ms 7.89 ± 0.33 ms 0.89 ± 0.053
init 0.0787 ± 0.028 ms 0.0799 ± 0.026 ms 0.986 ± 0.47
large_parameter_init/ODEProblem 27.1 ± 5.2 ms 30.8 ± 5.4 ms 0.879 ± 0.23
large_parameter_init/init 0.0835 ± 0.044 ms 0.0848 ± 0.017 ms 0.985 ± 0.56
mtkcompile 9.91 ± 0.31 ms 11.5 ± 0.52 ms 0.86 ± 0.047
sparse_analytical_jacobian/ODEProblem 28.4 ± 1.3 ms 0.032 ± 0.0011 s 0.888 ± 0.051
sparse_analytical_jacobian/f_iip 0.08 ± 0.01 μs 0.071 ± 0.01 μs 1.13 ± 0.21
sparse_analytical_jacobian/f_oop 0.392 ± 0.01 ms 0.394 ± 0.01 ms 0.995 ± 0.037
time_to_load 5.94 ± 0.035 s 6.34 ± 0.17 s 0.936 ± 0.025
Memory benchmarks
master 3cc7857... master / 3cc7857...
ODEProblem 31.5 k allocs: 1.93 MB 31.5 k allocs: 1.93 MB 1
init 0.416 k allocs: 0.0697 MB 0.416 k allocs: 0.0697 MB 1
large_parameter_init/ODEProblem 0.338 M allocs: 12.2 MB 0.338 M allocs: 12.2 MB 1
large_parameter_init/init 0.604 k allocs: 0.172 MB 0.604 k allocs: 0.172 MB 1
mtkcompile 0.0582 M allocs: 3.39 MB 0.0582 M allocs: 3.39 MB 1
sparse_analytical_jacobian/ODEProblem 0.201 M allocs: 8.43 MB 0.201 M allocs: 8.43 MB 1
sparse_analytical_jacobian/f_iip 0 allocs: 0 B 0 allocs: 0 B
sparse_analytical_jacobian/f_oop 0.634 k allocs: 19.6 kB 0.634 k allocs: 19.6 kB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master 3cc7857... master / 3cc7857...
ODEProblem 7.39 ± 2.5 ms 6.33 ± 0.59 ms 1.17 ± 0.41
init 0.0894 ± 0.014 ms 0.0765 ± 0.0086 ms 1.17 ± 0.23
large_parameter_init/ODEProblem 0.0423 ± 0.0097 s 30.8 ± 7.6 ms 1.37 ± 0.46
large_parameter_init/init 0.127 ± 0.049 ms 0.0847 ± 0.042 ms 1.5 ± 0.95
mtkcompile 11.1 ± 4.3 ms 9.38 ± 1.2 ms 1.18 ± 0.48
sparse_analytical_jacobian/ODEProblem 0.0339 ± 0.0042 s 28.6 ± 3.6 ms 1.19 ± 0.21
sparse_analytical_jacobian/f_iip 0.08 ± 0.01 μs 0.09 ± 0 μs 0.889 ± 0.11
sparse_analytical_jacobian/f_oop 0.131 ± 0.011 ms 0.124 ± 0.014 ms 1.05 ± 0.15
time_to_load 7.65 ± 0.32 s 5.51 ± 0.068 s 1.39 ± 0.061
Memory benchmarks
master 3cc7857... master / 3cc7857...
ODEProblem 30.1 k allocs: 1.77 MB 30.1 k allocs: 1.77 MB 1
init 0.415 k allocs: 0.0517 MB 0.415 k allocs: 0.0517 MB 1
large_parameter_init/ODEProblem 0.371 M allocs: 14.1 MB 0.371 M allocs: 14.1 MB 1
large_parameter_init/init 0.798 k allocs: 0.151 MB 0.798 k allocs: 0.151 MB 1
mtkcompile 0.0547 M allocs: 2.7 MB 0.0547 M allocs: 2.7 MB 1
sparse_analytical_jacobian/ODEProblem 0.195 M allocs: 7.48 MB 0.195 M allocs: 7.48 MB 1
sparse_analytical_jacobian/f_iip 0 allocs: 0 B 0 allocs: 0 B
sparse_analytical_jacobian/f_oop 0.848 k allocs: 27 kB 0.848 k allocs: 27 kB 1
time_to_load 0.146 k allocs: 11.4 kB 0.146 k allocs: 11.4 kB 1

@AayushSabharwal

Copy link
Copy Markdown
Member Author

Everything else is fine, I just missed a spot in InterfaceI. Will push the fix and merge once it passes.

@AayushSabharwal AayushSabharwal merged commit 3fe7562 into master Jul 1, 2026
70 of 88 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fix-ci branch July 1, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant