Fix ModelingToolkitBase QA metadata - #4737
Conversation
a63bada to
7d78ffb
Compare
|
Rebased onto current Post-rebase local checks on Julia 1.12.6:
CI has restarted on the rebased head. |
Add the missing Optimization test-extra compatibility bound. Keep SimpleNonlinearSolve as a hard dependency for MTKBifurcationKitExt activation and narrowly exempt that extension-only use from Aqua stale-dependency checking. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
7d78ffb to
9451997
Compare
|
Correction and final-base evidence for head
Before the exact lease-protected update I fetched both remotes and verified the feature branch still contained only the previous |
|
CI checkpoint: the only completed non-code failure so far is Doc Preview Cleanup run 29244404226. It was cancelled while |
|
Additional CI triage:
No #4737 source change is justified by these statuses. The magnetic fix remains under its own focused audit; the runner communication losses require a CI rerun rather than a code change. |
|
CI follow-up for the intended sublibrary downgrade job: the Optimization 5.x metadata change allows the ModelingToolkitBase minimum-compat run to resolve and proceed through InterfaceI (1,465 pass, 5 pre-existing broken) and most of InterfaceII (7,235 pass, 4 pre-existing broken). It then reports two errors in This is a deeper BVP/minimum-compat failure exposed after the dependency metadata issue; it is not caused by the focused compat/Aqua changes in this PR, so I am keeping it out of #4737 and queuing the required clean-main/bisection audit separately. The equivalent base check is also red, but its run is still active and its logs are unavailable, so I am not yet claiming the same root cause there. |
|
The two red benchmark checks are workflow mechanics, not benchmark/test failures:
No code change is indicated by either result. Julia 1 log · Julia LTS log |
|
Correction after the base job metadata became available: the base-branch ModelingToolkitBase downgrade check did not reach a Julia test failure. Its only annotation is “self-hosted runner lost communication with the server.” Therefore it provides no reproduction or counterexample for the head BVP dual-conversion errors. I will reproduce the head minimum-compat environment locally and determine whether the new Optimization compat exposes an incompatible lower bound or an independent downstream defect before changing #4737. |
|
This exact BVP failure already has a completed clean-master reproduce/bisect/fix audit in BoundaryValueDiffEq #559. That audit reproduced the same The new minimum-compat job selects MIRK 1.17.0/Core 2.7.1 and hits the same affected default-AD path. No additional ModelingToolkit code change should be folded into merged #4737. The dependency follow-up is to merge/release #559, then verify or raise ModelingToolkitBase’s BVP floor so its downgrade resolver cannot retain an affected Core stack. |
Please ignore this PR until reviewed by @ChrisRackauckas.
Summary
Optimization = "5.5"compatibility bound for the ModelingToolkitBase test extraSimpleNonlinearSolveas a hard dependencySimpleNonlinearSolvefrom Aqua's stale-dependency check because it is imported only byMTKBifurcationKitExtWhy the exemption is necessary
MTKBifurcationKitExtimportsSimpleNonlinearSolve, but the extension is intentionally activated by loadingBifurcationKitalone. MovingSimpleNonlinearSolveto an additional weak-dependency trigger would change that activation contract. Removing the hard dependency instead broke the extension suite, so this is an extension-only hard dependency rather than an unused dependency.The source comment records that invariant next to the narrow Aqua exemption. No tests are skipped, marked broken, or changed to warning-only behavior.
Local verification
Final head
9451997d80, based on upstreamf33a9699b5:git diff --check: exit 0The QA group intentionally still exits 1 for those three existing findings; this PR fixes only the metadata findings it targets.