Fix ModelingToolkitBase Aqua unbound arguments - #4738
Conversation
Remove unnecessary static parameters from parameter-buffer methods and use public type intersection for numeric array element types. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
7f5f709 to
d31e990
Compare
|
Rebased onto current upstream
|
|
Fresh rebased CI confirms this PR fixes its intended Aqua class in the full QA suite: |
|
Additional rebased-CI classification:
None is caused by the unbound-signature patch; the full MTKB QA lane confirms that intended Aqua class passes. |
|
The remaining newly completed sublibrary reds are existing clean-main clusters:
Jobs: https://github.com/SciML/ModelingToolkit.jl/actions/runs/29254919442/job/86832704083, https://github.com/SciML/ModelingToolkit.jl/actions/runs/29254919662/job/86834616845, https://github.com/SciML/ModelingToolkit.jl/actions/runs/29254919662/job/86834616620. |
Releases unreleased fixes on master: - ModelingToolkitBase 1.54.1 -> 1.54.2 (allow parameter-only equations after mtkcompile; unbound-variable fix (#4738)) - ModelingToolkit 11.35.0 -> 11.35.1 (avoid eliminating irreducibles in eliminate_zero_variables!) Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFmcAmLrGPrGtzwP333mX8
Summary
rm_unionmethods with publictypeintersectwhile preserving numeric array element typesUnion{Nothing, BigFloat}andUnion{Nothing, Float32}arraysThis is a focused part of #4670. It does not suppress or ignore Aqua findings.
Local verification
GROUP=SymbolicIndexingInterface: 64/64 SymbolicIndexingInterface, 1804/1804 SciML problem inputs, 118/118 MTKParameters; exit 0variable_utils.jl: parse-variable testsets 54/54 and 54/54, isinitial 7/7, At 13/13; exit 0Aqua.test_unbound_args(ModelingToolkitBase): exit 0GROUP=QA: JET 54/54; Aqua 7 pass / 4 fail, with unbound-argument checks passing. The full QA command exits 1 because this independent branch intentionally leaves the ambiguity, stale-dependency, missing-compat, and piracy classes for separate fixes.Ignore this PR until it has been reviewed by @ChrisRackauckas.