Raise ModelingToolkitBase SymbolicUtils floor to 4.35.3 - #4739
Merged
AayushSabharwal merged 1 commit intoJul 13, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
AayushSabharwal
marked this pull request as ready for review
July 13, 2026 11:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Ignore this PR until it has been reviewed by @ChrisRackauckas.
Summary
Cause and boundary
The ModelingToolkit floor change was introduced by SciML/ModelingToolkit.jl commit ab3a1fb, which changed the minimum from 4.34.1 to 4.35.2 while leaving the relevant test unchanged.
SymbolicUtils v4.35.2 still calls deprecated get_canonical_expr(ir, idx) in src/faster_code.jl, including the call reported at line 578 by the downgrade test. JuliaSymbolics/SymbolicUtils.jl commit df29cb30804d4ccacdb35297d3dc07e7c0c4ccea replaces all three calls with get_canonical_expr!. v4.35.3 is the first release tag containing that commit.
No existing ModelingToolkit issue or PR for the 4.35.3 floor was found before opening this PR.
Verification
Clean downgraded reproduction before the change:
After raising the floor:
The two full-group errors are the same independent BoundaryValueDiffEqMIRK ForwardDiff Dual-to-Float64 blocker already tracked in SciML/BoundaryValueDiffEq.jl#556 and addressed by draft SciML/BoundaryValueDiffEq.jl#559. No test was disabled, silenced, or loosened here.
Process
I reproduced the minimum-version workflow locally, inspected the ModelingToolkit compat history and unchanged regression across the introducing commit, inspected the SymbolicUtils commit/tag boundary, reran the official group, rebased onto the latest upstream master, and reran the focused regression plus formatting checks.