Drop unsupported DiffEqCallbacks 2 and 3 compat#4797
Merged
ChrisRackauckas merged 1 commit intoJul 20, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
Full CI classification after completion:
Thus the DiffEqCallbacks compat target is green and no remaining failure is introduced by this one-line change. |
ChrisRackauckas
marked this pull request as ready for review
July 20, 2026 22:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
The registry constraints cap DiffEqCallbacks 2.x and 3.x at SciMLBase 2.x. An explicit DiffEqCallbacks 3.9.1 plus SciMLBase 3.19 resolver probe is unsatisfiable for that reason.
I generated the deployed
alldepsminimum graph on the unmodified base, then repeated it after this one-line compat edit. Both graphs contain 298 packages, have an empty package/version/tree diff, and select DiffEqCallbacks 4.16.0 with SciMLBase 3.19.0. The two removed majors therefore do not represent a valid or exercised minimum graph.I then ran the real ModelingToolkitBase
InterfaceIgroup on Julia 1.10.11 with the candidate manifest locked (allow_reresolve=false):Additional checks:
852da7673a38b322c171b4400ea28d1faf47d02e8d4c7f390808df1343373a25during the locked testgit diff --check: passedPlease ignore this draft until it has been reviewed by @ChrisRackauckas.