Skip to content

Commit 89fbbcb

Browse files
Use SciMLTesting v1.0.0 (run_tests harness)
Replace the hand-written GROUP-dispatch in test/runtests.jl with a single declarative `run_tests` call from SciMLTesting v1.0.0. Pure harness refactor: the Core and QA (Aqua) test bodies are preserved verbatim (behavior-equivalent), only the dispatch boilerplate changes. QA is passed via the `qa` kwarg so it runs under both GROUP=QA and the "All" default, matching the original `GROUP == "QA" || GROUP == "All"` dispatch. Project.toml: add SciMLTesting to [extras]/[targets].test/[compat]. (No Pkg entry to remove here; the old harness did not use Pkg.) Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 4252111 commit 89fbbcb

2 files changed

Lines changed: 15 additions & 13 deletions

File tree

Project.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ SafeTestsets = "0.1"
3636
SciCompDSL = "1"
3737
SciMLBase = "2, 3"
3838
SciMLStructures = "1.7.0"
39+
SciMLTesting = "1"
3940
SymbolicIndexingInterface = "0.3.39"
4041
Symbolics = "7.4.1"
4142
Test = "1"
@@ -60,8 +61,9 @@ SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
6061
SciCompDSL = "91a8cdf1-4ca6-467b-a780-87fda3fff15e"
6162
SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
6263
SciMLStructures = "53ae85a6-f571-4167-b2af-e1d143709226"
64+
SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
6365
SymbolicIndexingInterface = "2efcf032-c050-4f8e-a9bb-153293bab1f5"
6466
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
6567

6668
[targets]
67-
test = ["ADTypes", "Aqua", "LinearAlgebra", "OrdinaryDiffEqBDF", "OrdinaryDiffEqDefault", "OrdinaryDiffEq", "OrdinaryDiffEqNonlinearSolve", "OrdinaryDiffEqRosenbrock", "OrdinaryDiffEqSDIRK", "SafeTestsets", "Test", "ControlSystemsBase", "DataFrames", "DataInterpolations", "SciMLBase", "SciMLStructures", "SymbolicIndexingInterface", "ForwardDiff", "SciCompDSL", "ModelingToolkit"]
69+
test = ["ADTypes", "Aqua", "LinearAlgebra", "OrdinaryDiffEqBDF", "OrdinaryDiffEqDefault", "OrdinaryDiffEq", "OrdinaryDiffEqNonlinearSolve", "OrdinaryDiffEqRosenbrock", "OrdinaryDiffEqSDIRK", "SafeTestsets", "SciMLTesting", "Test", "ControlSystemsBase", "DataFrames", "DataInterpolations", "SciMLBase", "SciMLStructures", "SymbolicIndexingInterface", "ForwardDiff", "SciCompDSL", "ModelingToolkit"]

test/runtests.jl

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,8 @@
11
using SafeTestsets, Test
2+
using SciMLTesting
23

3-
const GROUP = get(ENV, "GROUP", "All")
4-
5-
@time begin
6-
if GROUP == "QA" || GROUP == "All"
7-
@time @safetestset "Aqua" begin
8-
include("aqua.jl")
9-
end
10-
end
11-
12-
if GROUP == "Core" || GROUP == "All"
4+
run_tests(;
5+
core = () -> begin
136
@testset "Core" begin
147
# Blocks
158
@safetestset "Blocks: utils" begin
@@ -77,5 +70,12 @@ const GROUP = get(ENV, "GROUP", "All")
7770
include("Hydraulic/isothermal_compressible.jl")
7871
end
7972
end
80-
end
81-
end
73+
end,
74+
# QA (Aqua) runs in the main test env; pass via `qa` so it also runs under "All",
75+
# matching the original `GROUP == "QA" || GROUP == "All"` dispatch.
76+
qa = () -> begin
77+
@time @safetestset "Aqua" begin
78+
include("aqua.jl")
79+
end
80+
end,
81+
)

0 commit comments

Comments
 (0)