fix: drop stale _clamp import (un-break Blocks/math tests) - #458
Merged
ChrisRackauckas merged 1 commit intoJun 6, 2026
Merged
Conversation
test/Blocks/math.jl imported `_clamp` from Blocks, but `_clamp` was removed from the source — the Limiter component now calls the builtin `clamp` directly (src/Blocks/nonlinear.jl). The dead import made the 2nd Core testset error with `UndefVarError: _clamp` on every Julia/dep combination, so the whole suite (and downgrade CI) fails at master. `_clamp` is unused in the test; `_dead_zone` (still in source) is kept. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas
marked this pull request as ready for review
June 6, 2026 23:19
ChrisRackauckas
added a commit
that referenced
this pull request
Jun 7, 2026
Remove the `if: false` that was skipping the Downgrade workflow so it runs again under the centralized downgrade.yml@v1 (strict, allow_reresolve=false). The job is expected to be RED until the fntype regression (#458/#452) is resolved, at which point it auto-greens. Co-authored-by: Chris Rackauckas - Beep Boop Edition <accounts@chrisrackauckas.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the stale
_clampimport intest/Blocks/math.jl—_clampwas removed from the source (theLimitercomponent now uses the builtinclamp). The dead import errorsUndefVarError: _clampin the 2nd Core testset on every Julia/dep combination, redding master CI and blocking Downgrade re-enablement._clampis unused in the test;_dead_zone(still in source) is kept. Verified_clampappears nowhere else in the repo.🤖 Generated with Claude Code