Skip to content

qa: enforce strict SciMLTesting 2.4 checks - #497

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:codex/mtkstdlib-strict-v24-audit
Jul 29, 2026
Merged

qa: enforce strict SciMLTesting 2.4 checks#497
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:codex/mtkstdlib-strict-v24-audit

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Ignore until reviewed by @ChrisRackauckas.

Summary

  • require SciMLTesting 2.4 and use plain run_qa(ModelingToolkitStandardLibrary) without QA or documentation exceptions
  • replace package-owned non-public qualified accesses and resolve symbolic dispatch ambiguities exposed by strict QA
  • place connector docstrings on their original definitions and render public Blocks/domain API references
  • enable strict documentation checks, doctests, link checking, and clean docs builds
  • repair two analysis-point test operating points required by current ModelingToolkit initialization behavior

Validation

  • Pkg.test()
  • strict run_qa(ModelingToolkitStandardLibrary)
  • strict Documenter build with doctests, cross-reference checks, rendering, and link checking
  • Runic.main(["--check", "src", "test", "docs"])
  • git diff --check

The clean-main package test failure in test/test_analysis_points.jl was independently reproduced before correcting the missing loop-opening operating points.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review July 29, 2026 10:12
@ChrisRackauckas
ChrisRackauckas merged commit ebe7818 into SciML:main Jul 29, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants