Move JET into a separate QA test group#135
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Apr 27, 2026
Merged
Conversation
PR SciML#133's CI fails on Julia pre (1.13.0-beta3) at the Pkg.resolve step: JET 0.11.3 (its current max release) has no version compatible with Julia 1.13, so the entire main test environment cannot be instantiated. JET is a quality-assurance tool, not a runtime dependency, so blocking the main test matrix on its release cadence is the wrong tradeoff. Move JET to a dedicated QA group, mirroring how SciML/Sundials.jl ships JET/Aqua/ExplicitImports — `test/qa/` has its own `Project.toml` and `runtests.jl`, activated explicitly by a separate `QA.yml` workflow. The main `Tests.yml` matrix no longer installs JET and so resolves cleanly on Julia pre. Changes: - Add `test/qa/Project.toml` (deps: JET, MultiScaleArrays, Test) and `test/qa/runtests.jl` (runs `JET.report_package`, asserts zero reports). - Delete `test/jet_tests.jl` and remove the corresponding `@testset` from `test/runtests.jl`. - Drop `JET` from main `Project.toml` `[compat]`, `[extras]`, and the `test` target. - Add `.github/workflows/QA.yml` that runs `test/qa/runtests.jl` on Julia `1` and `lts` (skips `pre` since JET has no Julia 1.13 release yet). Verified locally on Julia 1.12.6: - `julia --project=test/qa test/qa/runtests.jl` -> Quality Assurance | 1 1 11.5s. - `julia --project=. -e 'using Pkg; Pkg.test()'` (main suite, no JET): Tuple Nodes / Bisect Search / Indexing and Creation / Values Indexing / Get Indices / Additional Fields / Dynamic DiffEq / Single Layer DiffEq / New Nodes — all pass; "Testing MultiScaleArrays tests passed". Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
82e1d5c to
1d93b74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #133's CI fails on Julia
pre(1.13.0-beta3) atPkg.resolve:JET 0.11.3 (its current max) has no version compatible with Julia 1.13, so the whole main test environment cannot be instantiated. JET is a QA tool, not a runtime dependency — blocking the main matrix on JET's release cadence is the wrong tradeoff.
This PR moves JET into a dedicated QA group, mirroring how SciML/Sundials.jl ships JET / Aqua / ExplicitImports.
Changes
test/qa/Project.toml(deps:JET,MultiScaleArrays,Test) andtest/qa/runtests.jl(runsJET.report_package, asserts zero reports).test/jet_tests.jland remove the corresponding@testsetfromtest/runtests.jl.JETfrom mainProject.toml[compat],[extras], and thetesttarget..github/workflows/QA.ymlthat runstest/qa/runtests.jlon Julia1andlts(skipspre).Local verification
Julia 1.12.6:
QA group:
Main test suite (no JET):
Test plan
Tests.ymlmatrix (1, lts, pre) all pass —preshould now succeed because main test deps no longer include JET.QA.ymlmatrix (1, lts) passes.test (alldeps, 1.10)(Downgrade) still passes at the new minimum.Companion to #134 (compat lower-bound bump). Either can land first.