Preserve residual shape in analytic JVPs - #1063
Conversation
|
The root downgrade job failed in the pre-existing Broyden robustness lane, not in SciMLJacobianOperators: Per the repository instructions, I have queued a separate clean-master reproduce/bisect/fix audit rather than changing or silencing the robustness assertion here. All other #1063 checks remain under monitoring. |
|
Prior-art check found that the clean-master downgrade failure is already fully audited in #1057: it reproduces the same generalized-Rosenbrock bad-Broyden case, bisects the first bad commit to |
|
Owning-package CI is now green across the full matrix: SciMLJacobianOperators Core passed on Julia lts, current release, and prerelease; QA passed on current release; and the strict sublibrary downgrade job passed. Runic and spell checks are also green. The only completed red remains the exact clean-master Broyden failure already fixed by #1057. |
|
Version-order note: draft #1060 independently uses SciMLJacobianOperators 0.1.16 (and NonlinearSolveFirstOrder 2.2.1). These are provisional next-version numbers, not interchangeable fixes. If #1060 merges first, this PR must rebase and become SciMLJacobianOperators 0.1.17, and dependent #1062 must raise its floor accordingly. If #1063/#1062 merge first, #1060 must take the later patch versions. No release should treat the shared provisional number as meaning both patches are present. |
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
f7c5c29 to
af90452
Compare
|
Post-#1060 rebase verification:
The rewritten branch was pushed with an exact lease against verified old SHA |
|
Early CI classification for the two red downgrade jobs on rebased head
Both logs are resolver failures before any test starts. This is the already-audited shared |
|
Additional rebased-head CI classification from the exact failed logs:
These failures are outside the SciMLJacobianOperators analytic-JVP diff and match the already-audited clean-master failures. No tests or broken-test bookkeeping were changed here. |
|
The remaining rebased-head failure is root CUDA: both The same two line-level failures have been observed on the clean-master CUDA lane, so this is being kept out of the analytic-JVP diff and queued for the required separate reproduce/bisect/fix audit on the GPU runner. No CUDA test is skipped or weakened here. |
|
The two newly completed macOS Core jobs match the same already-audited root Broyden regression:
This is the same cross-platform clean-master failure addressed by focused draft #1057 (with #1058 as the alternative dense fallback), so no additional test change or duplicate audit is needed here. |
|
The final macOS Core lane, Julia LTS, has now completed with the same sole generalized-Rosenbrock alg #4 residual ( |
|
Terminal CI follow-up: the final queued SimpleNonlinearSolve CUDA lane passed, bringing the run to 82 successes, 3 skipped matrix placeholders, and 10 previously classified failures. Those failures remain the clean-master downgrade resolver, NonlinearSolveBase ExplicitImports, root CUDA (addressed separately by #1066), and generalized-Rosenbrock root Core failures. No analytic-JVP-specific failure appeared. |
Ignore this PR until it has been reviewed by @ChrisRackauckas.
Summary
For a rectangular Jacobian, the product has one entry per residual. Reshaping it to
size(u)only worked when residual and unknown shapes happened to match.Verification
NONLINEARSOLVE_TEST_GROUP=Core julia +1.10 --project=lib/SciMLJacobianOperators -e "using Pkg; Pkg.instantiate(); Pkg.test()"git diff --check upstream/master...HEAD: exit 0This is the release prerequisite for #1062.