Skip to content

Preserve residual shape in analytic JVPs #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ChrisRackauckas-Claude wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Preserve residual shape in analytic JVPs #1063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/SciMLJacobianOperators/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "SciMLJacobianOperators"
uuid = "19f34311-ddf3-4b8b-af20-060888a46c0e"
version = "0.1.16"
version = "0.1.17"
authors = ["Avik Pal <avikpal@mit.edu> and contributors"]

[deps]
Expand Down
2 changes: 1 addition & 1 deletion lib/SciMLJacobianOperators/src/SciMLJacobianOperators.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ function prepare_jvp(
return
end
else
return @closure (v, u, p) -> reshape(f.jac(u, p) * vec(v), size(u))
return @closure (v, u, p) -> reshape(f.jac(u, p) * vec(v), size(fu))
end
end

Expand Down
20 changes: 20 additions & 0 deletions lib/SciMLJacobianOperators/test/core_tests__item3.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,3 +104,23 @@ prob = NonlinearProblem(
@test JᵀJv ≈ JᵀJv_analytic atol = 1.0e-5
end
end

rectangular_residual(u, p) = reshape(
[u[1] + u[2], 2 * u[1] - u[2], u[1] - 3 * u[2]], 3, 1
)
rectangular_jacobian(u, p) = [1 1; 2 -1; 1 -3]
rectangular_u = [2.0, 1.0]
rectangular_fu = rectangular_residual(rectangular_u, nothing)
rectangular_prob = NonlinearLeastSquaresProblem(
NonlinearFunction{false}(rectangular_residual; jac = rectangular_jacobian), rectangular_u
)

@testset "Rectangular Analytic Jacobian" begin
jac_op = JacobianOperator(rectangular_prob, rectangular_fu, rectangular_u)
sop = StatefulJacobianOperator(jac_op, rectangular_u, rectangular_prob.p)
v = [3.0, 2.0]

Jv = sop * v
@test size(Jv) == size(rectangular_fu)
@test Jv ≈ reshape(rectangular_jacobian(rectangular_u, nothing) * v, 3, 1)
end
Loading