Require operator-capable NonlinearSolveBase - #1079
Merged
ChrisRackauckas merged 1 commit intoJul 16, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This was referenced Jul 15, 2026
ChrisRackauckas
marked this pull request as ready for review
July 16, 2026 09:39
This was referenced Jul 16, 2026
ChrisRackauckas
added a commit
that referenced
this pull request
Jul 20, 2026
The source-tree sublibraries (NonlinearSolveBase, NonlinearSolveFirstOrder, NonlinearSolveQuasiNewton) require LinearSolve 5, but the root Project.toml floor was reverted to 4.3 in 60736b5 (#1079). The Downgrade workflow resolves the root project at its compat floors with the sublibraries fixed as path dependencies, so LinearSolve pinned at 4.3.0 conflicts with the sublibraries' strict LinearSolve = "5" requirement and resolution fails before any test runs. Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause and impact
NonlinearSolve 4.21.0 allows NonlinearSolveBase 2.31, so downgrade resolution can select NonlinearSolveBase 2.33. OrdinaryDiffEq's operator-backed nonlinear solve then reaches
similar(::SciMLOperators.MatrixOperator)and errors because that older base release does not use the operator-capable Jacobian path.Requiring NonlinearSolveBase 2.35 keeps the operator handling available under downgrade resolution. Restoring LinearSolve 4.3 compatibility avoids forcing downstream packages onto LinearSolve 5 when the registered NonlinearSolveBase 2.35 release supports and passes with both major lines.
Ignore this PR until it has been reviewed by @ChrisRackauckas.
Validation
GROUP=QAon Julia 1.10 with LinearSolve 5.0.0 and NonlinearSolveBase 2.35.0: 15/15 passedGROUP=Coreprogressed through all preceding groups successfully, then reproduced the existing Broyden baseline (94 passed, 1 failed, 1 unexpected pass, 19 broken). The same failure is present on unmodified master and was independently bisected to Quasi-Newton J⁻¹ init as a linsolve workspace: factorization + identity solve through the LinearSolve default #1039; Preserve triangular solves for Broyden Jacobian inversion #1057 contains the substantive fix and Brown bad-Broyden broken test is environment-sensitive #1056 tracks the Brown unexpected pass.