Skip to content

Commit 509f916

Browse files
SebastianM-Cclaude
andcommitted
test: unbreak ARC and TrustRegions retcode tests
These were marked broken because retcodes always returned Failure. Now that we properly use Manopt.has_converged, they correctly return Success. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent ebd66eb commit 509f916

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

lib/OptimizationManopt/test/runtests.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ R2 = Euclidean(2)
162162

163163
sol = OptimizationBase.solve(prob, opt)
164164
@test sol.objective < 0.1
165-
@test SciMLBase.successful_retcode(sol) broken = true
165+
@test SciMLBase.successful_retcode(sol)
166166
end
167167

168168
@testset "TrustRegions" begin
@@ -178,7 +178,7 @@ R2 = Euclidean(2)
178178

179179
sol = OptimizationBase.solve(prob, opt)
180180
@test sol.objective < 0.1
181-
@test SciMLBase.successful_retcode(sol) broken = true
181+
@test SciMLBase.successful_retcode(sol)
182182
end
183183

184184
@testset "Custom constraints" begin

0 commit comments

Comments
 (0)