Commit ebd66eb
fix: only add convergence criterion when abstol is explicitly set
Don't inject a default 1e-8 convergence criterion — let Manopt's own
per-solver defaults handle stopping. Each solver has tailored defaults
(e.g., GD uses StopWhenGradientNormLess(1e-8), ParticleSwarm uses
StopWhenChangeLess(1e-4), CMA-ES has multiple specialized criteria).
When no stopping criteria are specified at all, don't pass
stopping_criterion to the solver, letting Manopt use its built-in
defaults entirely.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent ec63927 commit ebd66eb
1 file changed
Lines changed: 7 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
366 | 367 | | |
367 | 368 | | |
368 | 369 | | |
369 | | - | |
370 | | - | |
| 370 | + | |
| 371 | + | |
371 | 372 | | |
372 | | - | |
| 373 | + | |
373 | 374 | | |
374 | 375 | | |
375 | 376 | | |
376 | 377 | | |
377 | | - | |
| 378 | + | |
378 | 379 | | |
379 | 380 | | |
380 | 381 | | |
| |||
0 commit comments