Avoid non-public promote_op in OptimizationBase#1249
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Avoid non-public promote_op in OptimizationBase#1249ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Member
|
Do an ignore/allow on promote_op here and use it. |
ChrisRackauckas-Claude
force-pushed
the
agent/fix-optimizationbase-promote-op-public-access
branch
from
July 10, 2026 01:49
25d5b3f to
e0d54ae
Compare
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas-Claude
force-pushed
the
agent/fix-optimizationbase-promote-op-public-access
branch
from
July 10, 2026 02:17
e0d54ae to
5cb560a
Compare
Member
Author
|
Current downstream status from the regression sweep:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be ignored until reviewed by @ChrisRackauckas.
Summary
Base.promote_opdependency inOptimizationDIExt.jlwith a local public-API output-eltype helper.p-accepting constraint Jacobian output buffer usable for dual and numeric parameter eltypes.Root cause
OptimizationBase QA on master failed
ExplicitImports.all_qualified_accesses_are_publicbecauseBase.promote_opis not public API.Verification
Reproduced on the pre-fix base (
59bdb75fe):OPTIMIZATION_TEST_GROUP=QA julia --project=lib/OptimizationBase -e 'import Pkg; Pkg.test()'NonPublicQualifiedAccessException:promote_opis not public inBase; summary16 passed, 1 errored, 1 broken.Verified on this rebased branch (
5cb560a08940f5592cd79b1654544afc6961d2f1):timeout 3600 env JULIA_DEPOT_PATH=/home/crackauc/sandbox/tmp_20260708_165240_11300/Optimization.jl/.julia-depot OPTIMIZATION_TEST_GROUP=QA julia --startup-file=no --project=lib/OptimizationBase -e 'import Pkg; Pkg.test(; coverage=false, julia_args=["--check-bounds=auto", "--compiled-modules=yes", "--depwarn=yes"], force_latest_compatible_version=false, allow_reresolve=true)'Quality Assurance | 17 pass, 1 broken, 18 total;Testing OptimizationBase tests passed.timeout 3600 env JULIA_DEPOT_PATH=/home/crackauc/sandbox/tmp_20260708_165240_11300/.julia-depot julia --startup-file=no --project=/home/crackauc/sandbox/tmp_20260708_165240_11300/.runic-env -m Runic --check lib/OptimizationBase/src/OptimizationDIExt.jlgit diff --check origin/master..HEAD