Fix NeuralPDE downstream groups#1259
Conversation
Execution log / scratchpad
No test was skipped, disabled, silenced, or loosened. |
|
CI downstream checkpoint for commit e9456cf:
The Julia prerelease Core failure was independently reproduced on clean upstream master b10c52b and reduced to Enzyme plus Julia LinearAlgebra; it is unrelated to this workflow patch and is being investigated separately. Upstream master has since advanced, so I am rebasing and will rerun local checks. |
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
e9456cf to
65e8b3c
Compare
|
Rebased onto current upstream master 0c663b6 and updated the branch with a lease-protected push. New patch commit: 65e8b3c. Post-rebase local verification:
The earlier focused-head CI results for NNPDE1 and NNPDE2 remain recorded above. Separate master-failure investigation: #1260. |
|
Current-head verification after @ChrisRackauckas applied commit 376ca38, removing the QA workflow-text assertion:
The functional downstream coverage remains the local NNPDE1/NNPDE2 runs and the passing CI results recorded above. Fresh workflows are running for this exact head. |
|
Current-head downstream results for 376ca38:
Documentation and every completed applicable workflow are green. ModelingToolkit downstream is still running. The sole test failure remains the independently reproduced Julia 1.13-rc1 / Enzyme 0.13.182 base issue tracked in #1260; stable Core, LTS Core, and QA all passed. |
This PR should be ignored until reviewed by @ChrisRackauckas.
Request
Summary
NNPDEdownstream job with separateNNPDE1andNNPDE2jobs.Root cause
NeuralPDE now declares folder-mode groups
NNPDE1andNNPDE2. Optimization.jl still requested the removed aggregateNNPDEgroup, so SciMLTesting rejected the downstream job before running NeuralPDE tests. The caller should request the groups NeuralPDE currently exposes instead of adding a compatibility alias to NeuralPDE, as proposed in the now-closed SciML/NeuralPDE.jl#1084.Impact
Optimization's downstream CI now exercises both halves of NeuralPDE's NNPDE suite in independent jobs. NeuralPDE's own test runner and generated CI matrix remain unchanged.
Local verification
GROUP=QA julia +1.12 --startup-file=no --project=. -e 'using Pkg; Pkg.test(; coverage=false)'QA | 18 pass, 1 broken, 19 totalTesting Optimization tests passedno_implicit_importsQA checkSciML/.github/.github/workflows/downstream.yml@v1locally against NeuralPDE masterbfcbae6ab850b6e785e33d7972cbba787eac97e9, withPkg.develop(PackageSpec(path="."))selecting this Optimization checkout:GROUP=NNPDE1 julia +1.12 --startup-file=no --project=downstream -e 'using Pkg; Pkg.develop(PackageSpec(path=".")); Pkg.update(); Pkg.test(; coverage=false)'Testing NeuralPDE tests passedGROUP=NNPDE2 julia +1.12 --startup-file=no --project=downstream -e 'using Pkg; Pkg.develop(PackageSpec(path=".")); Pkg.update(); Pkg.test(; coverage=false)'Testing NeuralPDE tests passedjulia +1.12 --startup-file=no --project=.runic-env -m Runic --check .actionlint .github/workflows/Downstream.ymlruby -e 'require "yaml"; YAML.load_file(".github/workflows/Downstream.yml"); puts "YAML parsed successfully"'git diff --check