Avoid BLAS dot in Enzyme lagrangian helper#1265
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Avoid
LinearAlgebra.dotin the Enzyme-only lagrangian helper used for constrained Hessian generation. The helper now accumulates the constraint contribution explicitly, which avoids the Julia 1.13-rc1/Enzymeijl_lazy_load_and_lookupderivative failure while preserving the same scalar value.Note: This PR should be ignored until reviewed by @ChrisRackauckas.
Why
lib/OptimizationBase / Julia pre / Tests - Coreis failing on currentmasterbefore the QA source-path cleanup PR can get a clean run. The failing stack is inOptimizationEnzymeExt.lagrangianthroughLinearAlgebra.dot.Observed master failure on
794eef029d3183bfdb20b122bf6b26b969a0875c:Validation
On a clean worktree at current master plus this commit:
passed:
Also ran: