Skip to content

Require LoggingExtras 1#1276

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:codex/require-loggingextras-1
Jul 20, 2026
Merged

Require LoggingExtras 1#1276
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:codex/require-loggingextras-1

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Summary

Ignore this PR until it has been reviewed by @ChrisRackauckas.

  • require LoggingExtras 1
  • retire the 0.4 compatibility line, which has been superseded by the stable 1.x series since 2022

This is intentionally a focused one-line compat change. LoggingExtras is used directly by the Optimization root package, so the exact downgrade graph and the current root test groups are validated separately.

Dependency

The clean base exact graph permits Optim 1.7.6, while the in-tree OptimizationOptimJL test source requires Optim 2. That independent root test-extra floor is handled by #1275. This LoggingExtras cleanup is therefore stacked and validated on top of #1275 while remaining a separate one-line review.

Local validation

  • Exact downgrade resolution on Julia 1.10: selected LoggingExtras 1.1.0.
  • Standalone exact-floor GROUP=Core on Julia 1.10: reached the clean-base Optim 1.7.6 versus OptimizationOptimJL Optim 2 resolver conflict before tests.
  • Exact-floor GROUP=Core stacked with the Optim 2 floor: passed (110 utility, 22 verbosity, 1 native optimization, 2 mini-batching, 14 interface, and 18 sense-handling assertions; 1 pre-existing broken mini-batching assertion).
  • Current-resolution GROUP=Core on Julia 1.12 with LoggingExtras 1.2.0: passed.
  • Current-resolution GROUP=QA on Julia 1.12: passed (18 passed, 1 pre-existing broken test).
  • Runic.main(["--check", "."]): passed.
  • git diff --check: passed.

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member Author

Scratchpad update for commit aea187ac5:

  • This branch is intentionally stacked on Require Optim 2 in root tests #1275 (aa577261d); after Require Optim 2 in root tests #1275 lands, the review diff reduces to the single LoggingExtras compat line.
  • Verified the exact Julia 1.10 graph selects LoggingExtras 1.1.0.
  • The standalone old-base floor run reached the independent Optim 1.7.6 versus in-tree OptimizationOptimJL Optim 2 conflict before tests.
  • On the Require Optim 2 in root tests #1275 stack, the locked exact-floor Core suite passed: 110 utility, 22 verbosity, 1 native optimization, 2 mini-batching, 14 interface, and 18 sense-handling assertions; the existing mini-batching broken assertion remained reported.
  • Reran current Julia 1.12 Core and QA on the final stack successfully (QA: 18 passed, 1 pre-existing broken check).
  • Runic and git diff --check pass.

No additional code changes are planned; this remains dependent on #1275.

@ChrisRackauckas-Claude
ChrisRackauckas-Claude force-pushed the codex/require-loggingextras-1 branch from aea187a to e599f2a Compare July 20, 2026 13:06

Copy link
Copy Markdown
Member Author

Rebased after #1275 merged.

  • fetched upstream/master and the remote feature branch before rewriting
  • verified the remote head still matched local aea187ac5 and both stacked commits were authored by ChrisRackauckas-Claude
  • Git skipped the already-merged Optim commit and replayed only the LoggingExtras change as e599f2a48
  • the tree hash remained exactly be8649207e00a4ee084a2d24801eaa99caac42ec, so the existing exact/current/QA/Runic validation still applies
  • pushed with an exact --force-with-lease

Copy link
Copy Markdown
Member Author

CI failure classification after clean-base reproduction:

  • Every root and sublibrary downgrade lane on this PR is green.
  • The QA failure is reproducible without this PR. Clean base 15368aacf and current master 4276a48c, both with SciMLTesting 2.3.0, fail only the rendered-public-docs check with the same 241 names: 18 passed, 1 failed, 1 pre-existing broken.
  • The introducing boundary is SciMLTesting 2.3.0: its first change enables rendered-doc checking by default. The same clean graph with SciMLTesting 2.2.0 passes the prior 18 checks plus the existing broken check.
  • Existing draft Use rendered public API docs QA #1272 is the correct fix. I merged it conflict-free into current master in an isolated checkout and ran the full GROUP=QA suite locally with SciMLTesting 2.3.0: 19 passed, 1 pre-existing broken, exit 0. The temporary merge was then aborted.
  • The Documentation job is unrelated to the patch: linkcheck received HTTP 429 from nlopt.readthedocs.io.

No test was skipped, disabled, or weakened, and no additional change belongs in this PR for either failure.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas-Claude
ChrisRackauckas-Claude force-pushed the codex/require-loggingextras-1 branch from e599f2a to 3c7a273 Compare July 20, 2026 16:31

Copy link
Copy Markdown
Member Author

Rebased onto current master (4276a48c, including the merged BBO deterministic-test fix) after confirming the remote branch still contained only our LoggingExtras commit. The lease-protected update rewrote the head to 3c7a273b0.

Post-rebase local verification on Julia 1.12:

  • GROUP=Core julia +1.12 --project=. -e 'using Pkg; Pkg.resolve(); Pkg.instantiate(); Pkg.test()'
  • Utils 110/110
  • Verbosity 22/22
  • Optimization 1/1
  • Mini batching 2 passed, 1 pre-existing broken
  • Interface Compatibility 14/14
  • Sense Handling 18/18
  • Testing Optimization tests passed
  • Repository-wide Runic check passed

The prior CI classification remains unchanged: all downgrade lanes were green; #1272 fixes the clean-current SciMLTesting 2.3 QA failure, and the documentation job's NLopt HTTP 429 is external.

@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review July 20, 2026 16:44
@ChrisRackauckas
ChrisRackauckas merged commit 34a8fd5 into SciML:master Jul 20, 2026
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants