Commit 8d5ed6a
Fix Multirate FastBroadcast compat and BDF convergence-test KeyError (#3386)
Two independent master test failures:
* OrdinaryDiffEqMultirate pins FastBroadcast = "0.3", but
OrdinaryDiffEqCore requires FastBroadcast = "1.3", so Pkg.Resolve
fails immediately. Bump the Multirate compat to "1.3" and bump the
package version to 1.0.1.
* The QNDF1 + AutoEnzyme + KrylovJL convergence test added by #3373
passes `reltol = 1.0e-14, abstol = 1.0e-14`. BDF-1's local error
floor exceeds double-precision near those tolerances, so Newton
hits ConvergenceFailure on every dt except the finest. Failed
solutions have an empty `sol.errors` dict, which then makes
DiffEqDevTools.ConvergenceSimulation crash with
`KeyError: key :l∞ not found` while iterating keys of the first
(successful) solution. Drop the tight-tolerance override for this
BDF case; the tightening from #3373 was only needed to avoid
LinearSolve's residual-tolerance coupling starving Rosenbrock
convergence, which is not a problem here. Locally verified:
QNDF1 + KrylovJL reports final/l2/l∞ order ≈ 1.0–1.17 on both
prob_ode_linear and prob_ode_2Dlinear (testTol = 0.2).
Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 27c848d commit 8d5ed6a
2 files changed
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
70 | 75 | | |
71 | 76 | | |
72 | 77 | | |
| |||
76 | 81 | | |
77 | 82 | | |
78 | 83 | | |
79 | | - | |
80 | | - | |
| 84 | + | |
81 | 85 | | |
82 | 86 | | |
83 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
0 commit comments