Leaping new controller interface

Author: termi-official

lib/OrdinaryDiffEqCore/src/integrators/controllers.jl

@@ -245,11 +245,6 @@ function sync_controllers!(cache1::IControllerCache, cache2::IControllerCache)
     return nothing
 end
 
-function sync_controllers!(cache1::IControllerCache, cache2::IControllerCache)
-    cache1.dtreject = cache2.dtreject
-    return nothing
-end
-
 # PI step size controller
 """
     PIController(beta1, beta2)
@@ -457,20 +452,20 @@ Some standard controller parameters suggested in the literature are
     [DOI: 10.1145/641876.641877](https://doi.org/10.1145/641876.641877)
   - Söderlind, Wang (2006)
     Adaptive time-stepping and computational stability
-    [DOI: 10.1016/j.cam.2005.03.008](https://doi.org/10.1016/j.cam.2005.03.008) # controller coefficients
-  - Ranocha, Dalcin, Parsani, Ketcheson (2021) # history of the error estimates
-    Optimized Runge-Kutta Methods with Automatic Step Size Control for   # accept a step if the predicted change of the step size
-    Compressible Computational Fluid Dynamics    # is bigger than this parameter
+    [DOI: 10.1016/j.cam.2005.03.008](https://doi.org/10.1016/j.cam.2005.03.008)
+  - Ranocha, Dalcin, Parsani, Ketcheson (2021)
+    Optimized Runge-Kutta Methods with Automatic Step Size Control for
+    Compressible Computational Fluid Dynamics
     [arXiv:2104.06836](https://arxiv.org/abs/2104.06836)    # limiter of the dt factor (before clipping)
 """
-struct PIDController{QT, Limiter} <: AbstractLegacyController
+struct PIDController{QT, Limiter} <: AbstractController
     beta::NTuple{3, QT} # controller coefficients
     err::MVector{3, QT} # history of the error estimates (mutable via indexing)
     accept_safety::QT   # accept a step if the predicted change of the step size
     # is bigger than this parameter
     limiter::Limiter    # limiter of the dt factor (before clipping)
-    qsteady_min::T
-    qsteady_max::T
+    qsteady_min::QT
+    qsteady_max::QT
 end
 
 @inline default_dt_factor_limiter(x) = one(x) + atan(x - one(x))

lib/StochasticDiffEqLeaping/src/algorithms.jl

@@ -32,7 +32,10 @@ Critical parameter: tau should be small enough that jump rates don't change sign
 
   - Gillespie, D.T., "Approximate accelerated stochastic simulation of chemically reacting systems"
 """
-struct TauLeaping <: StochasticDiffEqJumpAdaptiveAlgorithm end
+@kwdef struct TauLeaping{QT} <: StochasticDiffEqJumpAdaptiveAlgorithm
+  gamma::QT = 9 // 10
+  qmax::QT  = 10 // 1
+end
 
 """
     CaoTauLeaping()
@@ -74,7 +77,9 @@ Automatically adjusts tau based on:
 
   - Cao, Y., Gillespie, D.T., Petzold, L.R., "Efficient step size selection for the tau-leaping method"
 """
-struct CaoTauLeaping <: StochasticDiffEqJumpAdaptiveAlgorithm end
+@kwdef struct CaoTauLeaping <: StochasticDiffEqJumpAdaptiveAlgorithm
+  gamma::QT = 9 // 10
+end
 
 """
     ImplicitTauLeaping(; nlsolve=NLFunctional())

lib/StochasticDiffEqLeaping/src/stepsize_controllers.jl

@@ -10,12 +10,12 @@ function stepsize_controller!(integrator, alg::TauLeaping)
 end
 
 function step_accept_controller!(integrator, alg::TauLeaping)
-    integrator.q = min(integrator.opts.gamma / integrator.EEst, integrator.opts.qmax)
+    integrator.q = min(integrator.alg.gamma / integrator.EEst, integrator.alg.qmax)
     return integrator.dt * integrator.q
 end
 
 function step_reject_controller!(integrator, alg::TauLeaping)
-    return integrator.dt = integrator.opts.gamma * integrator.dt / integrator.EEst
+    return integrator.dt = integrator.alg.gamma * integrator.dt / integrator.EEst
 end
 
 function stepsize_controller!(integrator, alg::CaoTauLeaping)