Skip to content

Commit b7e332c

Browse files
ChrisRackauckas-ClaudeChrisRackauckasclaude
authored
Label ncondition as callback condition calls (#4058)
`ncondition` counts every callback condition evaluation, discrete included. Printing it as "rootfind condition calls" makes a solve with only discrete callbacks look like it is doing continuous-callback rootfinding, which sent a debugging session down the wrong path. Covers DiffEqBase's fallback `Stats` show method, used when SciMLBase does not define `DEStats`, and the DiffEqDevTools work-precision axis label that was copied from it. Claude-Session: https://claude.ai/code/session_01DKB6v14nZHZPYtKiLsPLDT Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent d78527d commit b7e332c

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

lib/DiffEqBase/src/stats.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ else
5252
@printf io "%-50s %-d\n" "Number of Jacobians created:" s.njacs
5353
@printf io "%-50s %-d\n" "Number of nonlinear solver iterations:" s.nnonliniter
5454
@printf io "%-50s %-d\n" "Number of nonlinear solver convergence failures:" s.nnonlinconvfail
55-
@printf io "%-50s %-d\n" "Number of rootfind condition calls:" s.ncondition
55+
@printf io "%-50s %-d\n" "Number of callback condition calls:" s.ncondition
5656
@printf io "%-50s %-d\n" "Number of accepted steps:" s.naccept
5757
@printf io "%-50s %-d" "Number of rejected steps:" s.nreject
5858
iszero(s.maxeig) || @printf io "\n%-50s %-d" "Maximum eigenvalue recorded:" s.maxeig

lib/DiffEqDevTools/Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "DiffEqDevTools"
22
uuid = "f3b72e0c-5b89-59e1-b016-84e28bfd966d"
33
authors = ["Chris Rackauckas <accounts@chrisrackauckas.com>"]
4-
version = "3.1.5"
4+
version = "3.1.6"
55

66
[deps]
77
CommonSolve = "38540f10-b2f7-11e9-35d8-d573e4eb0ff2"

lib/DiffEqDevTools/src/plotrecipes.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ function key_to_label(key::Symbol)
8585
elseif key == :nnonlinconvfail
8686
return "Number of nonlinear solver convergence failures"
8787
elseif key == :ncondition
88-
return "Number of rootfind condition calls"
88+
return "Number of callback condition calls"
8989
elseif key == :naccept
9090
return "Number of accepted steps"
9191
elseif key == :nreject

0 commit comments

Comments
 (0)