Skip to content

Commit e0d6877

Browse files
Fix faulty PID controller ctor
1 parent 64344b9 commit e0d6877

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

lib/OrdinaryDiffEqCore/src/integrators/controllers.jl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,6 @@ Some standard controller parameters suggested in the literature are
460460
"""
461461
struct PIDController{QT, Limiter} <: AbstractController
462462
beta::NTuple{3, QT} # controller coefficients
463-
err::MVector{3, QT} # history of the error estimates (mutable via indexing)
464463
accept_safety::QT # accept a step if the predicted change of the step size
465464
# is bigger than this parameter
466465
limiter::Limiter # limiter of the dt factor (before clipping)
@@ -501,10 +500,6 @@ function PIDController(QT, alg; beta = nothing, accept_safety = 0.81, limiter =
501500
QT(qsteady_min === nothing ? qsteady_min_default(alg) : qsteady_min),
502501
QT(qsteady_max === nothing ? qsteady_max_default(alg) : qsteady_max),
503502
)
504-
beta = map(float, promote(beta1, beta2, beta3))
505-
QT = eltype(beta)
506-
err = MVector{3, QT}(true, true, true)
507-
return PIDController(beta, err, convert(QT, accept_safety), limiter)
508503
end
509504

510505
function Base.show(io::IO, controller::PIDController)

0 commit comments

Comments
 (0)