Consolidate AlJahdali alg_cache into the generic 3S dispatch

Route the 16 AlJahdali methods through LowStorageRK3SAlgorithm and
_lowstorage_3s_tableau like the ParsaniKetcheson family, deleting the
32 hand-written per-method alg_cache definitions. Drop the positional
compatibility constructors: the methods are new so there is nothing to
be compatible with, and the positional form silently discarded a
passed stage limiter (the 3S kernel does not apply stage limiters).

Also document the 16 exports in the LowStorageRK docs page, match the
ConstantCache constructor signatures to the sibling families, and bump
OrdinaryDiffEqLowStorageRK to 3.3.0 for the new exports.

Verified behavior-preserving: end states for all 16 methods are
bit-identical to the pre-consolidation dispatch on in-place and
out-of-place problems, and the full LowStorageRK test file passes.

Author: singhharsh1708

docs/src/explicit/LowStorageRK.md

@@ -99,6 +99,22 @@ ParsaniKetchesonDeconinck3S94
 ParsaniKetchesonDeconinck3S184
 ParsaniKetchesonDeconinck3S105
 ParsaniKetchesonDeconinck3S205
+AlJahdaliAdv3S42
+AlJahdaliAdv3S82
+AlJahdaliAdv3S53
+AlJahdaliAdv3S113
+AlJahdaliAdv3S64
+AlJahdaliAdv3S154
+AlJahdaliAdv3S85
+AlJahdaliAdv3S165
+AlJahdaliVor3S42
+AlJahdaliVor3S82
+AlJahdaliVor3S53
+AlJahdaliVor3S113
+AlJahdaliVor3S64
+AlJahdaliVor3S154
+AlJahdaliVor3S85
+AlJahdaliVor3S165
 CKLLSRK43_2
 CKLLSRK54_3C
 CKLLSRK95_4S

lib/OrdinaryDiffEqLowStorageRK/Project.toml

@@ -1,7 +1,7 @@
 name = "OrdinaryDiffEqLowStorageRK"
 uuid = "b0944070-b475-4768-8dec-fb6eb410534d"
 authors = ["ParamThakkar123 <paramthakkar864@gmail.com>"]
-version = "3.2.2"
+version = "3.3.0"
 
 [deps]
 CommonSolve = "38540f10-b2f7-11e9-35d8-d573e4eb0ff2"

lib/OrdinaryDiffEqLowStorageRK/src/algorithms.jl

@@ -350,14 +350,6 @@ Base.@kwdef struct AlJahdaliAdv3S42{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliAdv3S42(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliAdv3S42{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 @doc explicit_rk_docstring(
     "Low-Storage Method
@@ -375,14 +367,6 @@ Base.@kwdef struct AlJahdaliAdv3S82{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliAdv3S82(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliAdv3S82{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 @doc explicit_rk_docstring(
     "Low-Storage Method
@@ -400,14 +384,6 @@ Base.@kwdef struct AlJahdaliAdv3S53{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliAdv3S53(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliAdv3S53{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 @doc explicit_rk_docstring(
     "Low-Storage Method
@@ -425,14 +401,6 @@ Base.@kwdef struct AlJahdaliAdv3S113{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliAdv3S113(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliAdv3S113{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 @doc explicit_rk_docstring(
     "Low-Storage Method
@@ -450,14 +418,6 @@ Base.@kwdef struct AlJahdaliAdv3S64{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliAdv3S64(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliAdv3S64{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 @doc explicit_rk_docstring(
     "Low-Storage Method
@@ -475,14 +435,6 @@ Base.@kwdef struct AlJahdaliAdv3S154{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliAdv3S154(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliAdv3S154{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 @doc explicit_rk_docstring(
     "Low-Storage Method
@@ -500,14 +452,6 @@ Base.@kwdef struct AlJahdaliAdv3S85{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliAdv3S85(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliAdv3S85{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 @doc explicit_rk_docstring(
     "Low-Storage Method
@@ -525,14 +469,6 @@ Base.@kwdef struct AlJahdaliAdv3S165{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliAdv3S165(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliAdv3S165{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 # Vortex-optimized schemes
 
@@ -552,14 +488,6 @@ Base.@kwdef struct AlJahdaliVor3S42{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliVor3S42(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliVor3S42{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 @doc explicit_rk_docstring(
     "Low-Storage Method
@@ -577,14 +505,6 @@ Base.@kwdef struct AlJahdaliVor3S82{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliVor3S82(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliVor3S82{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 @doc explicit_rk_docstring(
     "Low-Storage Method
@@ -602,14 +522,6 @@ Base.@kwdef struct AlJahdaliVor3S53{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliVor3S53(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliVor3S53{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 @doc explicit_rk_docstring(
     "Low-Storage Method
@@ -627,14 +539,6 @@ Base.@kwdef struct AlJahdaliVor3S113{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliVor3S113(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliVor3S113{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 @doc explicit_rk_docstring(
     "Low-Storage Method
@@ -652,14 +556,6 @@ Base.@kwdef struct AlJahdaliVor3S64{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliVor3S64(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliVor3S64{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 @doc explicit_rk_docstring(
     "Low-Storage Method
@@ -677,14 +573,6 @@ Base.@kwdef struct AlJahdaliVor3S154{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliVor3S154(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliVor3S154{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 @doc explicit_rk_docstring(
     "Low-Storage Method
@@ -702,14 +590,6 @@ Base.@kwdef struct AlJahdaliVor3S85{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliVor3S85(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliVor3S85{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 @doc explicit_rk_docstring(
     "Low-Storage Method
@@ -727,14 +607,6 @@ Base.@kwdef struct AlJahdaliVor3S165{StageLimiter, StepLimiter, Thread} <:
     step_limiter!::StepLimiter = trivial_limiter!
     thread::Thread = Serial()
 end
-# for backwards compatibility
-function AlJahdaliVor3S165(stage_limiter!, step_limiter! = trivial_limiter!)
-    return AlJahdaliVor3S165{typeof(stage_limiter!), typeof(step_limiter!), Serial}(
-        stage_limiter!,
-        step_limiter!,
-        Serial()
-    )
-end
 
 @doc explicit_rk_docstring(
     "Low-Storage Method