Controller interface for v7#3312
Closed
termi-official wants to merge 0 commit intoSciML:v7from
Closed
Conversation
termi-official
force-pushed
the
do/break-controller-interface-v7
branch
from
1ae361c to
31d075e
Compare
ChrisRackauckas
force-pushed
the
v7
branch
2 times, most recently
from
c3ec6e5 to
cb38e96
Compare
termi-official
force-pushed
the
do/break-controller-interface-v7
branch
2 times, most recently
from
4342ec9 to
d146c8d
Compare
termi-official
commented
Apr 10, 2026
Comment on lines
427
to
434
| function default_controller(QT, alg) | ||
| if ispredictive(alg) | ||
| return NewPredictiveController(QT, alg) | ||
| return PredictiveController(QT, alg) | ||
| elseif isstandard(alg) | ||
| return NewIController(QT, alg) | ||
| return IController(QT, alg) | ||
| else | ||
| return NewPIController(QT, alg) | ||
| return PIController(QT, alg) | ||
| end |
Contributor
Author
There was a problem hiding this comment.
Since we are breaking stuff right now anyway, this part of the setup workflow here is something which we might want to think about. I think we should
- Purge isstandard/ispredictive
- Algorithms with special controllers should just dispatch on
default_controller(see e.g. lib/OrdinaryDiffEqLowStorageRK/src/alg_utils.jl) - In all other cases we return a standard PI or PID controller with reasonable (and algorithm order sensitive) default parameters.
| return PIController(beta1, beta2) | ||
| end | ||
| end | ||
| # FIXME AitkenNeville is missing integration with the extrapolation controller and picks up the PI controller instead. |
Contributor
Author
There was a problem hiding this comment.
I don't know how to fix this, as I do not know enough about the theory here.
termi-official
force-pushed
the
do/break-controller-interface-v7
branch
from
9eb65dd to
1f18dc7
Compare
ChrisRackauckas
force-pushed
the
v7
branch
8 times, most recently
from
089c49a to
ff14144
Compare
termi-official
force-pushed
the
do/break-controller-interface-v7
branch
from
e0d6877 to
98ab4b0
Compare
Contributor
Author
|
I will open a separate PR again with the code. Some git operation failed and the branch is broken now. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
Follow Up