Force type specialization of ESDIRK*L2SA tableau dispatches#3654
Merged
ChrisRackauckas merged 1 commit intoMay 19, 2026
Merged
Conversation
The _pure_esdirk_to_imex_tableau helper took stage count as runtime
Int from size(Ai_mat, 1); now takes ::Val{S} so dispatch infers
ESDIRKIMEXTableau{S, T, T2, :standard} concretely.
Contributor
Author
|
@ChrisRackauckas Re: your review on #3651 about type specialization of the ESDIRKIMEXTableau(::Alg, T, T2) dispatches — turned out 5 of them (the ESDIRK*L2SA family) were inferring as abstract ESDIRKIMEXTableau{_A, …} where _A because _pure_esdirk_to_imex_tableau was reading stage count as a runtime Int from size(Ai_mat, 1). Fixed by making the helper take ::Val{S} and passing Val(s) from each caller (they already had s = N as a local literal). All 23 dispatches now inline to concrete ESDIRKIMEXTableau{S, T, T2, E}. SDIRK convergence + DAE suites still pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _pure_esdirk_to_imex_tableau helper took stage count as runtime Int from size(Ai_mat, 1); now takes ::Val{S} so dispatch infers ESDIRKIMEXTableau{S, T, T2, :standard} concretely.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.