nlstep tests: unbreak NSA(TrustRegion) order assertions that now pass - #3897
Closed
singhharsh1708 wants to merge 1 commit into
Closed
nlstep tests: unbreak NSA(TrustRegion) order assertions that now pass#3897singhharsh1708 wants to merge 1 commit into
singhharsh1708 wants to merge 1 commit into
Conversation
Member
|
I already got these running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four
@test_brokenorder assertions inmodelingtoolkit/nlstep_tests.jlnow pass, so the MTK lane reports them asUnexpected Passand errors out:All four are
NonlinearSolveAlg(TrustRegion())convergence-order checks — TRBDF2 and QNDF2, in both the non-autonomous and autonomous Robertson blocks. They were the failures behind #3807 and #3818, and the recent NonlinearSolve releases (SciML/NonlinearSolve.jl#1010 recomputing the trust-region radius onreinit!, plus #1008) fixed them upstream.This flips those four to
@test. The two KenCarp4 order-4 assertions still fail and stay@test_broken.Verified on a clean checkout of master (8ed2f7a): before,
19 passed, 0 failed, 4 errored, 2 broken; after,23 passed, 2 broken, 0 errored. The same 4 errors show up on the MTK lane of every open PR that touches this sublibrary, which is what makes that lane red.AI Disclosure
Claude assisted with this work.