From cccae35423b4e911403fe975b57c5d437b0c32da Mon Sep 17 00:00:00 2001 From: singhharsh1708 Date: Mon, 13 Jul 2026 16:48:11 +0530 Subject: [PATCH] nlstep tests: unbreak NSA(TrustRegion) order assertions that now pass --- .../test/modelingtoolkit/nlstep_tests.jl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/OrdinaryDiffEqNonlinearSolve/test/modelingtoolkit/nlstep_tests.jl b/lib/OrdinaryDiffEqNonlinearSolve/test/modelingtoolkit/nlstep_tests.jl index 3d40c9ab73..473d42d0da 100644 --- a/lib/OrdinaryDiffEqNonlinearSolve/test/modelingtoolkit/nlstep_tests.jl +++ b/lib/OrdinaryDiffEqNonlinearSolve/test/modelingtoolkit/nlstep_tests.jl @@ -46,7 +46,7 @@ sol2 = solve(testprob, TRBDF2(autodiff = AutoFiniteDiff(), nlsolve = nlalg), ada test_setup = Dict(:alg => FBDF(), :reltol => 1.0e-14, :abstol => 1.0e-14) dts = 2.0 .^ (-10:-1:-15) sim = analyticless_test_convergence(dts, testprob, TRBDF2(autodiff = AutoFiniteDiff(), nlsolve = nlalgrobust), test_setup); -@test_broken abs(sim.đ’Șest[:l∞] - 2) < 0.2 +@test abs(sim.đ’Șest[:l∞] - 2) < 0.2 dts = 2.0 .^ (-10:-1:-12) sim = analyticless_test_convergence(dts, testprob, KenCarp4(autodiff = AutoFiniteDiff(), nlsolve = nlalgrobust), test_setup); @@ -58,7 +58,7 @@ sim = analyticless_test_convergence(dts, testprob, ABDF2(autodiff = AutoFiniteDi dts = 2.0 .^ (-13:-1:-16) sim = analyticless_test_convergence(dts, testprob, QNDF2(autodiff = AutoFiniteDiff(), nlsolve = nlalgrobust), test_setup); -@test_broken abs(sim.đ’Șest[:l∞] - 2.5) < 0.2 # Superconvergence +@test abs(sim.đ’Șest[:l∞] - 2.5) < 0.2 # Superconvergence dts = 2.0 .^ (-14:-1:-17) sim = analyticless_test_convergence(dts, testprob, FBDF(autodiff = AutoFiniteDiff(), nlsolve = nlalgrobust), test_setup); @@ -102,7 +102,7 @@ sol2 = solve(testprob, TRBDF2(autodiff = AutoFiniteDiff(), nlsolve = nlalg), ada test_setup = Dict(:alg => FBDF(), :reltol => 1.0e-14, :abstol => 1.0e-14) dts = 2.0 .^ (-10:-1:-15) sim = analyticless_test_convergence(dts, testprob, TRBDF2(autodiff = AutoFiniteDiff(), nlsolve = nlalgrobust), test_setup); -@test_broken abs(sim.đ’Șest[:l∞] - 2) < 0.2 +@test abs(sim.đ’Șest[:l∞] - 2) < 0.2 dts = 2.0 .^ (-10:-1:-12) sim = analyticless_test_convergence(dts, testprob, KenCarp4(autodiff = AutoFiniteDiff(), nlsolve = nlalgrobust), test_setup); @@ -114,7 +114,7 @@ sim = analyticless_test_convergence(dts, testprob, ABDF2(autodiff = AutoFiniteDi dts = 2.0 .^ (-13:-1:-16) sim = analyticless_test_convergence(dts, testprob, QNDF2(autodiff = AutoFiniteDiff(), nlsolve = nlalgrobust), test_setup); -@test_broken abs(sim.đ’Șest[:l∞] - 2.5) < 0.2 # Superconvergence +@test abs(sim.đ’Șest[:l∞] - 2.5) < 0.2 # Superconvergence dts = 2.0 .^ (-14:-1:-17) sim = analyticless_test_convergence(dts, testprob, FBDF(autodiff = AutoFiniteDiff(), nlsolve = nlalgrobust), test_setup);