Skip to content

Add SparseConnectivityTracer test compat - #3927

Merged
ChrisRackauckas merged 2 commits into
SciML:masterfrom
ChrisRackauckas-Claude:agent/sct-test-compat
Jul 21, 2026
Merged

Add SparseConnectivityTracer test compat#3927
ChrisRackauckas merged 2 commits into
SciML:masterfrom
ChrisRackauckas-Claude:agent/sct-test-compat

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Ignore this PR until it has been reviewed by @ChrisRackauckas.

Summary

  • add a SparseConnectivityTracer = "1" compat bound for the matrix-free NonlinearSolveAlg test dependency
  • bump OrdinaryDiffEqNonlinearSolve from 2.3.0 to 2.3.1

Root cause

Commit 9a2f7e7b7 added SparseConnectivityTracer to test extras for TracerSparsityDetector() but omitted its compat entry. Aqua therefore fails the OrdinaryDiffEqNonlinearSolve QA lane. The 1.x bound targets the stable API series containing the exported ADTypes sparsity detector used by the test.

Validation

  • Aqua.test_deps_compat(OrdinaryDiffEqNonlinearSolve) on Julia 1.11: passed 4/4, including the extras check
  • exact ODEDIFFEQ_TEST_GROUP=QA julia +1.11 --project=lib/OrdinaryDiffEqNonlinearSolve -e "using Pkg; Pkg.test()": compat bounds passed 4/4; the run remains red only on the 11 pre-existing cross-sublibrary public-API errors tracked in ExplicitImports: drive sublibrary QA checks to green (ei_broken markers) #3776
  • julia +1.12 -m Runic --check --diff --verbose .: all 1000 Julia files passed

This PR does not add an ExplicitImports allowance or otherwise silence #3776.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member Author

Four-hour CI checkpoint

The scheduled timer expired at 2026-07-16 22:00:07 EDT; this snapshot was collected immediately afterward.

Branch / PR state

  • Fetched both upstream and origin: the branch is 0 commits behind upstream/master and 1 commit ahead.
  • The worktree is clean and matches origin/agent/sct-test-compat.
  • PR remains a draft, GitHub reports it MERGEABLE, and mergeStateStatus is UNSTABLE because of the classified failing checks below.
  • Full rollup: 170 checks — 146 successful, 20 failed, 3 skipped, 1 queued.
  • The only incomplete check is StochasticDiffEq NoncommutativeConvergence, still queued with no runner assigned.

Patch-relevant OrdinaryDiffEqNonlinearSolve lanes

Remaining failures

The 20 completed failures classify into existing master failure buckets:

No completed failure attributable to this SCT compatibility-only patch was found.

Local verification

@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review July 21, 2026 21:22
@ChrisRackauckas
ChrisRackauckas merged commit 1b1d32c into SciML:master Jul 21, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants