Skip to content

Align MuladdMacro downgrade floors with PureKLU #3981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 2 commits into from
Jul 22, 2026
Merged

Align MuladdMacro downgrade floors with PureKLU #3981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dbe10c
Align MuladdMacro floors with PureKLU
ChrisRackauckas Jul 22, 2026
c6590be
Cover all Core-coupled MuladdMacro floors
ChrisRackauckas Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqAdamsBashforthMoulton/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Test = "<0.0.1, 1"
FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
SciMLBase = "3.35.1"
OrdinaryDiffEqCore = "4"
OrdinaryDiffEqLowOrderRK = "2"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqBDF/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
DifferentiationInterface = "0.7.18"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
LinearSolve = "3.75.0, 4"
PrecompileTools = "1.2.1, 1.3"
LinearAlgebra = "1.10"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqCore/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ LinearAlgebra = "1.10"
Logging = "1.10"
MacroTools = "0.5.6"
Mooncake = "0.4, 0.5"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
OrdinaryDiffEqFIRK = "2"
OrdinaryDiffEqRosenbrock = "2"
OrdinaryDiffEqTsit5 = "2"
Expand Down
3 changes: 1 addition & 2 deletions lib/OrdinaryDiffEqExplicitRK/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Test = "<0.0.1, 1"
FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
LinearAlgebra = "1.10"
TruncatedStacktraces = "1.4"
SciMLBase = "3.35.1"
Expand All @@ -49,4 +49,3 @@ test = ["DiffEqDevTools", "Random", "SafeTestsets", "Test", "Pkg", "SciMLTesting

[sources.OrdinaryDiffEqCore]
path = "../OrdinaryDiffEqCore"

2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqExponentialRK/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Test = "<0.0.1, 1"
FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
OrdinaryDiffEqVerner = "2"
LinearSolve = "3.75.0, 4"
ExponentialUtilities = "1.27"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqExtrapolation/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Test = "<0.0.1, 1"
FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
LinearSolve = "3.75.0, 4"
OrdinaryDiffEqDifferentiation = "3"
SciMLBase = "3.35.1"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqFIRK/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
FastGaussQuadrature = "1.2"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
LinearSolve = "3.75.0, 4"
LinearAlgebra = "1.10"
OrdinaryDiffEqDifferentiation = "3"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqFeagin/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Test = "<0.0.1, 1"
FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
SciMLBase = "3.35.1"
OrdinaryDiffEqCore = "4"
julia = "1.10"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqFunctionMap/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Test = "<0.0.1, 1"
FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
SciMLBase = "3.35.1"
ODEProblemLibrary = "1"
OrdinaryDiffEq = "7"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqHighOrderRK/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Test = "<0.0.1, 1"
FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
SciMLBase = "3.35.1"
OrdinaryDiffEqCore = "4"
julia = "1.10"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqLowOrderRK/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Test = "<0.0.1, 1"
FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
LinearAlgebra = "1.10"
SciMLBase = "3.35.1"
OrdinaryDiffEqCore = "4"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqLowStorageRK/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
StructArrays = "0.6, 0.7"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
PrecompileTools = "1.2.1, 1.3"
SciMLBase = "3.35.1"
SciMLOperators = "1.24.3"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqMultirate/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ DiffEqBase = "7"
DiffEqDevTools = "3"
FastBroadcast = "1.3"
JET = "0.9, 0.11"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
OrdinaryDiffEqCore = "4"
OrdinaryDiffEqDifferentiation = "3"
OrdinaryDiffEqLowOrderRK = "2"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqNonlinearSolve/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Test = "<0.0.1, 1"
FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
LinearSolve = "3.75.0, 4"
LineSearches = "7.5.1"
LinearAlgebra = "1.10"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqNordsieck/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Test = "<0.0.1, 1"
FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
LinearAlgebra = "1.10"
SciMLBase = "3.35.1"
OrdinaryDiffEqCore = "4.4"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqPDIRK/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ ADTypes = "1.22.0"
DiffEqBase = "7"
DiffEqDevTools = "3"
FastBroadcast = "1.3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
ODEProblemLibrary = "1"
OrdinaryDiffEqCore = "4"
OrdinaryDiffEqDifferentiation = "3"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqPRK/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Test = "<0.0.1, 1"
FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
SciMLBase = "3.35.1"
OrdinaryDiffEqCore = "4"
julia = "1.10"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqQPRK/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Test = "<0.0.1, 1"
FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
SciMLBase = "3.35.1"
OrdinaryDiffEqCore = "4"
julia = "1.10"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqRKN/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Test = "<0.0.1, 1"
FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
SciMLBase = "3.35.1"
OrdinaryDiffEqCore = "4"
julia = "1.10"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqRosenbrock/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ ForwardDiff = "1.3.3"
LinearAlgebra = "1.10"
LinearSolve = "3.75.0, 4"
MacroTools = "0.5.6"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
ODEProblemLibrary = "1"
OrdinaryDiffEqCore = "4.6"
OrdinaryDiffEqDifferentiation = "3.2.1"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqSDIRK/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
DifferentiationInterface = "0.7.18"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
LinearAlgebra = "1.10"
OrdinaryDiffEqDifferentiation = "3"
TruncatedStacktraces = "1.4"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqSIMDRK/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Pkg = "1"
Test = "<0.0.1, 1"
DiffEqDevTools = "3"
FastBroadcast = "1.3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
OrdinaryDiffEqCore = "4"
SLEEFPirates = "0.6.43"
VectorizationBase = "0.21.70"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqSSPRK/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
StructArrays = "0.6, 0.7"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
PrecompileTools = "1.2.1, 1.3"
SciMLBase = "3.35.1"
OrdinaryDiffEqCore = "4"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqStabilizedRK/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Test = "<0.0.1, 1"
FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
LinearAlgebra = "1.10"
SciMLBase = "3.35.1"
OrdinaryDiffEqCore = "4"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqSymplecticRK/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Test = "<0.0.1, 1"
FastBroadcast = "1.3"
Random = "<0.0.1, 1"
DiffEqDevTools = "3"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
LinearAlgebra = "1.10"
OrdinaryDiffEqRKN = "2"
SciMLBase = "3.35.1"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqTaylorSeries/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ DiffEqDevTools = "3"
FastBroadcast = "1.3"
FunctionWrappers = "1.1.3"
LinearAlgebra = "1.10"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
ODEProblemLibrary = "1"
OrdinaryDiffEqCore = "4"
OrderedCollections = "1"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqTsit5/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ DiffEqBase = "7"
DiffEqDevTools = "3"
FastBroadcast = "1.3"
LinearAlgebra = "1.10"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
OrdinaryDiffEqCore = "4"
Pkg = "1"
PrecompileTools = "1.2.1, 1.3"
Expand Down
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqVerner/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Random = "<0.0.1, 1"
DiffEqDevTools = "3"
OrdinaryDiffEqExplicitRK = "2"
OrdinaryDiffEqExplicitTableaus = "2"
MuladdMacro = "0.2.1"
MuladdMacro = "0.2.4"
PrecompileTools = "1.2.1, 1.3"
LinearAlgebra = "1.10"
TruncatedStacktraces = "1.4"
Expand Down
24 changes: 24 additions & 0 deletions test/qa/qa_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,30 @@
using SciMLTesting, OrdinaryDiffEq, SciMLBase
using Test

@testset "PureKLU-compatible MuladdMacro floors" begin
lib_dir = joinpath(@__DIR__, "..", "..", "lib")
projects = filter(readdir(lib_dir)) do package
project_path = joinpath(lib_dir, package, "Project.toml")
isfile(project_path) || return false
project = read(project_path, String)
has_muladdmacro = occursin(
r"(?m)^MuladdMacro = \"[0-9]+\.[0-9]+\.[0-9]+", project
)
uses_core = package == "OrdinaryDiffEqCore" ||
occursin(r"(?m)^OrdinaryDiffEqCore = ", project)
has_muladdmacro && uses_core
end
@test length(projects) == 39
for package in projects
project = read(joinpath(lib_dir, package, "Project.toml"), String)
floor_match = match(r"(?m)^MuladdMacro = \"([0-9]+\.[0-9]+\.[0-9]+)", project)
@test floor_match !== nothing
if floor_match !== nothing
@test VersionNumber(floor_match[1]) >= v"0.2.4"
end
end
end

# The umbrella package's QA lane historically ran only the ExplicitImports checks
# (no Aqua/JET), so keep `aqua = false` to preserve that scope.
run_qa(
Expand Down
Loading