Skip to content

Run Runic on the disco-optimizations files - #4064

Draft
ChrisRackauckas-Claude wants to merge 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:format/runic-disco-optimizations
Draft

Run Runic on the disco-optimizations files#4064
ChrisRackauckas-Claude wants to merge 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:format/runic-disco-optimizations

Conversation

@ChrisRackauckas-Claude

@ChrisRackauckas-Claude ChrisRackauckas-Claude commented Jul 29, 2026

Copy link
Copy Markdown
Member

Please ignore until reviewed by @ChrisRackauckas.

Motivation

The DISCO optimization merge (#3720) left three files that Runic rejects, so
format-check fails on current master and on every PR based on it.

The aggregate whole-tree failure begins at 408a7a30fe. Per-file bisects place
disco.jl and disco_tests.jl at that commit and
integrators/controllers.jl at 80d7e74c82; the relevant files at parent
c538565b25 all pass.

What this does

Runs Runic on exactly the three affected files:

  • lib/OrdinaryDiffEqCore/src/disco.jl
  • lib/OrdinaryDiffEqCore/src/integrators/controllers.jl
  • test/Integrators_I/disco_tests.jl

The diff contains only Runic's whitespace, line-wrapping, numeric-literal, and
explicit-return normalization. There is no behavioral or public-API change.
Formatting exact clean master produces the same 38-insertion/34-deletion tree
as this PR.

Local validation

At rebased head 5c05be4605 on upstream b22e2e58b2:

  • Runic 1.7.0, whole tree: pass (--check ., exit 0)
  • git diff --check: pass
  • git range-diff against the prior PR commit: exact (=)
  • official GROUP=Integrators_I on the coherent #4064 + #4066 validation
    stack: Step Limiter 251/251, DISCO 28/28, package tests passed in 2882.56 s

The #4066 compatibility commit is validation-only context and is not included
in this branch. An independent #3985 + #4066 + #4064 validation also passed
homotopy tests 38/38, default nonlinear-solve tests 16/16, whole-tree Runic,
and git diff --check.

Hosted CI

At the one-hour terminal audit, hosted Runic, Runic suggestions, and Typos were
green. The remaining 241 failures all stopped before tests: 127 sublibrary
setup jobs, 44 root setup jobs, 12 downstream resolvers, documentation, and 57
downgrade resolvers. Representative setup logs report the separate SciMLBase
3.39/3.40 boundary fixed by #4066; the downgrade jobs stop inside their
resolver. No hosted failure is in this formatting diff.

No version bump is needed for a formatting-only change.

Checklist

  • No new test is required for a formatting-only change
  • No public API is changed
  • Whole-tree Runic and git diff --check pass
  • The affected official test group passes on the coherent local-source stack

The disco-optimizations merge (SciML#3720) landed three files that Runic rejects, so
format-check has been failing on master for every PR since. Whitespace and line
wrapping only; `runic --check .` is clean across the repo afterwards.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DKB6v14nZHZPYtKiLsPLDT
@ChrisRackauckas-Claude
ChrisRackauckas-Claude force-pushed the format/runic-disco-optimizations branch from 0172415 to 5c05be4 Compare July 30, 2026 00:50

Copy link
Copy Markdown
Member Author

Rebase/validation checkpoint for head 5c05be4605:

  • rebased the formatting-only commit onto current upstream b22e2e58b2; git range-diff reports the patch as exact (=)
  • whole-repository Runic passed locally
  • the official GROUP=Integrators_I harness passed locally on the coherent #4064 + #4066 validation stack
    • Step Limiter Tests: 251/251
    • Discontinuity Detection Tests: 28/28
    • Testing OrdinaryDiffEq tests passed
    • total group runtime: 2882.56 seconds
  • fetched both upstream and the fork immediately before updating the branch; upstream was still b22e2e58b2, and the remote branch was still our prior 0172415aaf head with no contributor commits, so the rebased head was pushed with an exact-SHA --force-with-lease

The #4066 commit remains test-only validation context and is not included in this branch.

Copy link
Copy Markdown
Member Author

Clean-master bisect refinement (independent checkout at b22e2e58b2):

  • the aggregate whole-tree Runic failure begins at 408a7a30fe (disco optimizations);
  • lib/OrdinaryDiffEqCore/src/disco.jl and test/Integrators_I/disco_tests.jl are first bad at that same commit;
  • lib/OrdinaryDiffEqCore/src/integrators/controllers.jl becomes nonconforming later at 80d7e74c82;
  • all three relevant files pass at parent c538565b25;
  • formatting exact clean master produces the same 38-insertion/34-deletion tree as this PR head, and whole-tree Runic then passes.

This confirms #4064 is the existing focused fix for the complete clean-master formatter regression; no duplicate PR was opened.

Copy link
Copy Markdown
Member Author

One-hour terminal CI audit for rebased head 5c05be4605: 9 checks succeeded, 3 were skipped, and 241 failed. The hosted Runic format check is green; none of the 241 failures is in this formatting patch.

Exact breakdown:

  • 127 sublibrary jobs stopped before tests (126 in julia-buildpkg, one developing local Core sources). Representative logs from both paths show registered SciMLBase 3.39.1 versus the current local 3.40 floor fixed by Restore SciMLBase 3.39 compatibility for owner imports #4066.
  • all 44 root test jobs stopped before tests (29 in julia-buildpkg, 15 developing in-repo sources) at the same compatibility boundary.
  • all 12 external downstream failure logs were checked individually; every one contains a SciMLBase unsatisfiable requirement before downstream tests.
  • documentation stopped at the same resolver boundary.
  • 56 sublibrary downgrade jobs and the root downgrade job stopped inside the downgrade resolver before tests.

The actual formatting checks are green: hosted Runic / Runic Format Check, Runic suggestions, and Typos all succeeded. Local whole-tree Runic and the official 48-minute Integrators_I validation (251/251 Step Limiter, 28/28 DISCO) remain the behavior gate. The rebased #4066 compatibility prerequisite is now pushed separately at 661bd35c64; no dependency change belongs in this formatting-only PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants