Skip to content

Initialize the DISCO checkpoint from the time value #4069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Jul 29, 2026
+6 −2
Merged

Initialize the DISCO checkpoint from the time value #4069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqCore/src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,7 @@ Base.@constprop :aggressive function _ode_init(
controller_cache = setup_controller_cache(_alg, cache, controller, EEstT, disco_probs)

is_disco_step = false
disco_checkpoint = zero(tType)
disco_checkpoint = zero(t)
# Seed the initial EEst on the controller cache (was previously
# `integrator.EEst = oneunit(EEstT)`).
set_EEst!(controller_cache, EEst)
Expand Down
6 changes: 5 additions & 1 deletion test/Downstream/dynamicquantities_measurements.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ using Test
f(u, p, t) = u / (1u"s")
prob = ODEProblem(f, u0, tspan)

sol = solve(prob, Tsit5(); abstol = 1.0e-9, reltol = 1.0e-9)
integrator = init(prob, Tsit5(); abstol = 1.0e-9, reltol = 1.0e-9)
@test integrator.disco_checkpoint == zero(first(tspan))
@test typeof(integrator.disco_checkpoint) == typeof(first(tspan))

sol = solve!(integrator)

@test sol.u[end] isa typeof(u0)
@test eltype(sol.u) == typeof(u0)
Expand Down
Loading