Skip to content

Test FunctionMap keyword compatibility #4070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 2 commits into from
Aug 1, 2026
+21 −2
Merged

Test FunctionMap keyword compatibility #4070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f1f110
Use public APIs for FunctionMap keyword validation
ChrisRackauckas Jul 29, 2026
6b4b7e3
Allow Base.structdiff in FunctionMap QA
ChrisRackauckas Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions lib/OrdinaryDiffEqFunctionMap/test/discrete_algorithm_test.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,17 @@ end

@test sol3.u == [[0, 0], [1, 1], [2, 3], [3, 6], [4, 10], [5, 15]]
end

@testset "FunctionMap keyword validation" begin
current_limiter!(u, integrator, p, t) = nothing
legacy_limiter!(u, integrator, p, t) = nothing

@test FunctionMap(step_limiter = current_limiter!).step_limiter! === current_limiter!
@test FunctionMap(; step_limiter! = legacy_limiter!).step_limiter! === legacy_limiter!
@test_throws ArgumentError("Unsupported keyword argument(s): (:unsupported,)") FunctionMap(
unsupported = true
)
@test_throws ArgumentError(
"Unsupported keyword argument(s): (:unsupported, :also_unsupported)"
) FunctionMap(unsupported = true, also_unsupported = true)
end
9 changes: 7 additions & 2 deletions lib/OrdinaryDiffEqFunctionMap/test/qa/qa.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,14 @@ run_qa(
# OrdinaryDiffEqCore owner-internal no-op limiter (deliberately not public).
ignore = (:trivial_limiter!,),
),
# SciMLBase-owned default-solve sentinels; non-public in SciMLBase.
all_qualified_accesses_are_public = (;
ignore = (:DISCRETE_INPLACE_DEFAULT, :DISCRETE_OUTOFPLACE_DEFAULT),
ignore = (
# SciMLBase-owned default-solve sentinels; non-public in SciMLBase.
:DISCRETE_INPLACE_DEFAULT,
:DISCRETE_OUTOFPLACE_DEFAULT,
# Preserves the statically known NamedTuple type after field removal.
:structdiff,
),
),
),
)
Loading