Restore DelayDiffEq extension hooks as public API - #4073
Merged
ChrisRackauckas merged 1 commit intoJul 29, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
Investigation scratchpad:
|
ChrisRackauckas
marked this pull request as ready for review
July 29, 2026 21:32
Member
Author
|
CI dependency note: the two immediate downgrade failures ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Summary
Base.ispublicregression tests.Root cause
#3832 split the public and developer API documentation, but it also demoted cross-sublibrary hooks while DelayDiffEq continued to use them. A history bisect identifies
e1db9b088674f7804a971100210631ac0c801104from that PR as the first bad commit.Ten names are restorations of the preexisting public surface.
resolve_stage_step_limitersandtrivial_limiter!were introduced after that demotion and are additive APIs in the already-unreleased OrdinaryDiffEqCore 4.12.0 release; current General has OrdinaryDiffEqCore 4.11.0.Dependency
This PR depends on #4066 for the clean current-master test environment to resolve. The resolver change is intentionally not duplicated here.
Validation
GROUP=DelayDiffEq_QAon Julia 1.12, stacked on Restore SciMLBase 3.39 compatibility for owner imports #4066: clean baseline was 17 passed / 2 errored (exit 1); this patch is 19/19 passed (exit 0), with the same SciMLTesting 2.6.1, ExplicitImports 1.15.0, and SciMLBase 3.39.1 dependencies.GROUP=OrdinaryDiffEqCore_QAon Julia 1.12: passed (exit 0).GROUP=OrdinaryDiffEqNonlinearSolve_QAon Julia 1.12: passed (exit 0).GROUP=OrdinaryDiffEqDefault_QAstill reports the independentlorenz_pref/lorenz_pref_paramsprivate-helper access on both this branch and a cleane5489faa+ #4066 control (18 passed / 1 errored, exit 1). That preexisting failure is deliberately not folded into this focused API-restoration PR.