Import MatrixOperator from SciMLOperators in integrator tests - #4076
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Conversation
The tests currently receive MatrixOperator through SciMLBase's accidental SciMLOperators reexport. Import it directly so the test files continue to run once that reexport is removed. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
One-hour terminal CI audit for exact head Breakdown:
Local source-stack validation remains the evidence for behavior: registered-stack Events 57/57 and Step Limiter 251/251; owner-clean SciMLBase 3.40.1 Events 57/57 and all Step Limiter sections 251/251 total. No resolver workaround or unrelated formatting change is included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Summary
MatrixOperatordirectly from its public owner, SciMLOperators, in the Events test.Investigation
These isolated test files currently receive
MatrixOperatorindirectly through SciMLBase's former@reexport using SciMLOperators.7b806c50(v3.40.0) still makesMatrixOperatorvisible afterusing SciMLBase.b9c3507aremoves the SciMLOperators reexport, so the name is no longer visible through SciMLBase.MatrixOperatorpublic and exported, has its constructor docstring, and renders it indocs/src/premade_operators.md.This is therefore an owner-import cleanup and forward-stack runtime fix. It is not a failure with the currently registered stack: master itself first hits the independent SciMLBase floor conflict tracked by #4066, and master plus #4066 resolves SciMLBase 3.39.1, where both test files still pass through the old reexport.
With the owner-clean local SciMLBase 3.40.1 source stack, the unmodified Events test errors with
UndefVarError: MatrixOperator not defined. The direct imports remove that dependency on a transitive binding.Local validation
Runic --check .— passed.Integrators_Iharness, Events: 57/57 passed.Pkg.test-generated environment:The #4066 and #4075 commits were used only in disposable validation worktrees and are absent from this branch.