Preserve AD wrappers in Rosenbrock stages - #4101
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
|
Doesn't JuliaArrays/ArrayInterface.jl#498 cover this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArrayPartition, unless the struct-of-arrays conversion matches the original container typeinit/solve!pathRoot cause
The first commit of #3996 (
100fe236) replaced the former reshape helper withArrayInterface.restructure. For an out-of-place ReverseDiff state, that changes aTrackedArraytemplate into a plainVector{TrackedReal}, and the Rosenbrock stage update later attempts to convert the tracked scalars back toFloat64.The focused reproducer passes at the parent commit (
5e3c607) and fails at100fe236. Converting the restructured result with the publicArrayInterface.aos_to_soaAPI restores the tracked wrapper. The type guard avoids changing other state-container representations.Validation
GROUP=Core julia +1.10 --project=lib/OrdinaryDiffEqRosenbrock -e 'using Pkg; Pkg.test()'Ignore this PR until reviewed by @ChrisRackauckas.