Skip to content

Commit 334bd95

Browse files
author
rokke
committed
use new syntax in tests
1 parent 51da3fe commit 334bd95

File tree

8 files changed

+128
-123
lines changed

8 files changed

+128
-123
lines changed

test/basic_indexing.jl

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ testa = cat(recs..., dims = 2)
66
testva = VectorOfArray(recs)
77
@test maximum(testva) == maximum(maximum.(recs))
88

9+
testva = VA[[1, 2, 3], [4, 5, 6], [7, 8, 9]]
10+
@test maximum(testva) == maximum(maximum.(recs))
11+
912
# broadcast with array
1013
X = rand(3, 3)
1114
mulX = sqrt.(abs.(testva .* X))
@@ -161,15 +164,15 @@ diffeq = DiffEqArray(recs, t)
161164
@test diffeq[:, (end - 1):end].t == t[(length(t) - 1):length(t)]
162165

163166
# Test views of heterogeneous arrays (issue #453)
164-
f = VectorOfArray([[1.0], [2.0, 3.0]])
167+
f = VA[[1.0], [2.0, 3.0]]
165168
@test length(view(f, :, 1)) == 1
166169
@test length(view(f, :, 2)) == 2
167170
@test view(f, :, 1) == [1.0]
168171
@test view(f, :, 2) == [2.0, 3.0]
169172
@test collect(view(f, :, 1)) == f[:, 1]
170173
@test collect(view(f, :, 2)) == f[:, 2]
171174

172-
f2 = VectorOfArray([[1.0, 2.0], [3.0]])
175+
f2 = VA[[1.0, 2.0], [3.0]]
173176
@test length(view(f2, :, 1)) == 2
174177
@test length(view(f2, :, 2)) == 1
175178
@test view(f2, :, 1) == [1.0, 2.0]
@@ -178,7 +181,7 @@ f2 = VectorOfArray([[1.0, 2.0], [3.0]])
178181
@test collect(view(f2, :, 2)) == f2[:, 2]
179182

180183
# Test `end` with ragged arrays
181-
ragged = VectorOfArray([[1.0, 2.0], [3.0, 4.0, 5.0], [6.0, 7.0, 8.0, 9.0]])
184+
ragged = VA[[1.0, 2.0], [3.0, 4.0, 5.0], [6.0, 7.0, 8.0, 9.0]]
182185
@test ragged[end, 1] == 2.0
183186
@test ragged[end, 2] == 5.0
184187
@test ragged[end, 3] == 9.0
@@ -192,7 +195,7 @@ ragged = VectorOfArray([[1.0, 2.0], [3.0, 4.0, 5.0], [6.0, 7.0, 8.0, 9.0]])
192195
@test ragged[:, 2:end] == VectorOfArray(ragged.u[2:end])
193196
@test ragged[:, (end - 1):end] == VectorOfArray(ragged.u[(end - 1):end])
194197

195-
ragged2 = VectorOfArray([[1.0, 2.0, 3.0, 4.0], [5.0, 6.0], [7.0, 8.0, 9.0]])
198+
ragged2 = VA[[1.0, 2.0, 3.0, 4.0], [5.0, 6.0], [7.0, 8.0, 9.0]]
196199
@test ragged2[end, 1] == 4.0
197200
@test ragged2[end, 2] == 6.0
198201
@test ragged2[end, 3] == 9.0
@@ -228,7 +231,7 @@ ragged_range_idx = 1:lastindex(ragged, 1)
228231
@test identity.(ragged_range_idx) === ragged_range_idx
229232

230233
# Broadcasting of heterogeneous arrays (issue #454)
231-
u = VectorOfArray([[1.0], [2.0, 3.0]])
234+
u = VA[[1.0], [2.0, 3.0]]
232235
@test length(view(u, :, 1)) == 1
233236
@test length(view(u, :, 2)) == 2
234237
# broadcast assignment into selected column (last index Int)
@@ -293,7 +296,7 @@ u[1:2, 1, [1, 3], 2] .= [1.0 3.0; 2.0 4.0]
293296
@test u[end, 1, end] == u.u[end][end, 1, end]
294297

295298
# Test that views can be modified
296-
f3 = VectorOfArray([[1.0, 2.0], [3.0, 4.0, 5.0]])
299+
f3 = VA[[1.0, 2.0], [3.0, 4.0, 5.0]]
297300
v = view(f3, :, 2)
298301
@test length(v) == 3
299302
v[1] = 10.0
@@ -384,7 +387,7 @@ mulX .= sqrt.(abs.(testva .* testvb))
384387
@test mulX == ref
385388

386389
# https://github.com/SciML/RecursiveArrayTools.jl/issues/49
387-
a = ArrayPartition(1:5, 1:6)
390+
a = AP[1:5, 1:6]
388391
a[1:8]
389392
a[[1, 3, 8]]
390393

test/downstream/downstream_events.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
using OrdinaryDiffEq, StaticArrays, RecursiveArrayTools
2-
u0 = ArrayPartition(SVector{1}(50.0), SVector{1}(0.0))
2+
u0 = AP[SVector{1}(50.0), SVector{1}(0.0)]
33
tspan = (0.0, 15.0)
44

55
function f(u, p, t)
6-
return ArrayPartition(SVector{1}(u[2]), SVector{1}(-9.81))
6+
return AP[SVector{1}(u[2]), SVector{1}(-9.81)]
77
end
88

99
prob = ODEProblem(f, u0, tspan)
@@ -13,7 +13,7 @@ function condition(u, t, integrator) # Event when event_f(u,t,k) == 0
1313
end
1414

1515
affect! = nothingf = affect_neg! = function (integrator)
16-
return integrator.u = ArrayPartition(SVector{1}(integrator.u[1]), SVector{1}(-integrator.u[2]))
16+
return integrator.u = AP[SVector{1}(integrator.u[1]), SVector{1}(-integrator.u[2])]
1717
end
1818

1919
callback = ContinuousCallback(condition, affect!, affect_neg!, interp_points = 100)

test/downstream/odesolve.jl

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ function lorenz(du, u, p, t)
44
du[2] = u[1] * (28.0 - u[3]) - u[2]
55
return du[3] = u[1] * u[2] - (8 / 3) * u[3]
66
end
7-
u0 = ArrayPartition([1.0, 0.0], [0.0])
7+
u0 = AP[[1.0, 0.0], [0.0]]
88
@test ArrayInterface.zeromatrix(u0) isa Matrix
99
tspan = (0.0, 100.0)
1010
prob = ODEProblem(lorenz, u0, tspan)
@@ -25,26 +25,26 @@ function mymodel(F, vars)
2525
return
2626
end
2727
# To show that the function works
28-
F = ArrayPartition([0.0 0.0; 0.0 0.0], [0.0 0.0; 0.0 0.0])
29-
u0 = ArrayPartition([0.1 1.2; 0.1 1.2], [0.1 1.2; 0.1 1.2])
28+
F = AP[[0.0 0.0; 0.0 0.0], [0.0 0.0; 0.0 0.0]]
29+
u0 = AP[[0.1 1.2; 0.1 1.2], [0.1 1.2; 0.1 1.2]]
3030
result = mymodel(F, u0)
3131
nlsolve(mymodel, u0)
3232

3333
# Nested ArrayPartition solves
3434

3535
function dyn(u, p, t)
3636
return ArrayPartition(
37-
ArrayPartition(zeros(1), [0.0]),
38-
ArrayPartition(zeros(1), [0.0])
37+
AP[zeros(1), [0.0]],
38+
AP[zeros(1), [0.0]]
3939
)
4040
end
4141

4242
@test solve(
4343
ODEProblem(
4444
dyn,
4545
ArrayPartition(
46-
ArrayPartition(zeros(1), [-1.0]),
47-
ArrayPartition(zeros(1), [0.75])
46+
AP[zeros(1), [-1.0]],
47+
AP[zeros(1), [0.75]]
4848
),
4949
(0.0, 1.0)
5050
),
@@ -55,8 +55,8 @@ end
5555
ODEProblem(
5656
dyn,
5757
ArrayPartition(
58-
ArrayPartition(zeros(1), [-1.0]),
59-
ArrayPartition(zeros(1), [0.75])
58+
AP[zeros(1), [-1.0]],
59+
AP[zeros(1), [0.75]]
6060
),
6161
(0.0, 1.0)
6262
),

test/interface_tests.jl

Lines changed: 33 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ using FastBroadcast
33
using SymbolicIndexingInterface: SymbolCache
44

55
t = 1:3
6-
testva = VectorOfArray([[1, 2, 3], [4, 5, 6], [7, 8, 9]])
6+
testva = VA[[1, 2, 3], [4, 5, 6], [7, 8, 9]]
77
testda = DiffEqArray([[1, 2, 3], [4, 5, 6], [7, 8, 9]], t)
88

99
for (i, elem) in enumerate(testva)
@@ -64,7 +64,7 @@ push!(testda, [-1, -2, -3, -4])
6464

6565
# Type inference
6666
@inferred sum(testva)
67-
@inferred sum(VectorOfArray([VectorOfArray([zeros(4, 4)])]))
67+
@inferred sum(VA[VA[zeros(4, 4)]])
6868
@inferred mapreduce(string, *, testva)
6969
# Type stability for `end` indexing (issue #525)
7070
testva_end = VectorOfArray(fill(fill(2.0, 2), 10))
@@ -79,7 +79,7 @@ last_row = lastindex(testva_end, 1)
7979
@test testva_end[last_row, 1] == 2.0
8080

8181
# mapreduce
82-
testva = VectorOfArray([[1, 2, 3], [4, 5, 6], [7, 8, 9]])
82+
testva = VA[[1, 2, 3], [4, 5, 6], [7, 8, 9]]
8383
@test mapreduce(x -> string(x) * "q", *, testva) == "1q2q3q4q5q6q7q8q9q"
8484

8585
testvb = VectorOfArray([rand(1:10, 3, 3, 3) for _ in 1:4])
@@ -128,7 +128,7 @@ end
128128
@test stack(testva) == [1 4 7; 2 5 8; 3 6 9]
129129
@test stack(testva; dims = 1) == [1 2 3; 4 5 6; 7 8 9]
130130

131-
testva = VectorOfArray([VectorOfArray([ones(2, 2), 2ones(2, 2)]), 3ones(2, 2, 2)])
131+
testva = VA[VA[ones(2, 2), 2ones(2, 2)], 3ones(2, 2, 2)]
132132
@test stack(testva) ==
133133
[1.0 1.0; 1.0 1.0;;; 2.0 2.0; 2.0 2.0;;;; 3.0 3.0; 3.0 3.0;;; 3.0 3.0; 3.0 3.0]
134134

@@ -180,29 +180,22 @@ testva = VectorOfArray([i * ones(3, 2) for i in 1:4])
180180
arr = rand(3, 2, 4)
181181
copyto!(testva, arr)
182182
@test Array(testva) == arr
183-
testva = VectorOfArray(
184-
[
185-
ones(3, 2, 2),
186-
VectorOfArray(
187-
[
188-
2ones(3, 2),
189-
VectorOfArray([3ones(3), 4ones(3)]),
190-
]
191-
),
192-
DiffEqArray(
193-
[
194-
5ones(3, 2),
195-
VectorOfArray(
196-
[
197-
6ones(3),
198-
7ones(3),
199-
]
200-
),
201-
], [0.1, 0.2],
202-
[100.0, 200.0], SymbolCache([:x, :y], [:a, :b], :t)
203-
),
204-
]
205-
)
183+
testva = VA[
184+
ones(3, 2, 2),
185+
VA[
186+
2ones(3, 2),
187+
VA[3ones(3), 4ones(3)],
188+
],
189+
DiffEqArray(
190+
[
191+
5ones(3, 2),
192+
VA[6ones(3), 7ones(3)],
193+
],
194+
[0.1, 0.2],
195+
[100.0, 200.0],
196+
SymbolCache([:x, :y], [:a, :b], :t)
197+
),
198+
]
206199
arr = rand(3, 2, 2, 3)
207200
copyto!(testva, arr)
208201
@test Array(testva) == arr
@@ -244,16 +237,16 @@ resize!(u, 3)
244237
@test pointer(u) === pointer(u.u)
245238

246239
# Ensure broadcast (including assignment) works with StaticArrays
247-
x = VectorOfArray([fill(2, SVector{2, Float64}), ones(SVector{2, Float64})])
248-
y = VectorOfArray([fill(2, SVector{2, Float64}), ones(SVector{2, Float64})])
249-
z = VectorOfArray([zeros(SVector{2, Float64}), zeros(SVector{2, Float64})])
240+
x = VA[fill(2, SVector{2, Float64}), ones(SVector{2, Float64})]
241+
y = VA[fill(2, SVector{2, Float64}), ones(SVector{2, Float64})]
242+
z = VA[zeros(SVector{2, Float64}), zeros(SVector{2, Float64})]
250243
z .= x .+ y
251244

252-
@test z == VectorOfArray([fill(4, SVector{2, Float64}), fill(2, SVector{2, Float64})])
245+
@test z == VA[fill(4, SVector{2, Float64}), fill(2, SVector{2, Float64})]
253246

254-
u1 = VectorOfArray([fill(2, SVector{2, Float64}), ones(SVector{2, Float64})])
255-
u2 = VectorOfArray([fill(4, SVector{2, Float64}), 2 .* ones(SVector{2, Float64})])
256-
u3 = VectorOfArray([fill(4, SVector{2, Float64}), 2 .* ones(SVector{2, Float64})])
247+
u1 = VA[fill(2, SVector{2, Float64}), ones(SVector{2, Float64})]
248+
u2 = VA[fill(4, SVector{2, Float64}), 2 .* ones(SVector{2, Float64})]
249+
u3 = VA[fill(4, SVector{2, Float64}), 2 .* ones(SVector{2, Float64})]
257250

258251
function f(u1, u2, u3)
259252
return u3 .= u1 .+ u2
@@ -265,9 +258,9 @@ yy = [2.0 1.0; 2.0 1.0]
265258
zz = x .+ yy
266259
@test zz == [4.0 2.0; 4.0 2.0]
267260

268-
z = VectorOfArray([zeros(SVector{2, Float64}), zeros(SVector{2, Float64})])
261+
z = VA[zeros(SVector{2, Float64}), zeros(SVector{2, Float64})]
269262
z .= zz
270-
@test z == VectorOfArray([fill(4, SVector{2, Float64}), fill(2, SVector{2, Float64})])
263+
@test z == VA[fill(4, SVector{2, Float64}), fill(2, SVector{2, Float64})]
271264

272265
function f!(z, zz)
273266
return z .= zz
@@ -276,7 +269,7 @@ f!(z, zz)
276269
@test (@allocated f!(z, zz)) == 0
277270

278271
z .= 0.1
279-
@test z == VectorOfArray([fill(0.1, SVector{2, Float64}), fill(0.1, SVector{2, Float64})])
272+
@test z == VA[fill(0.1, SVector{2, Float64}), fill(0.1, SVector{2, Float64})]
280273

281274
function f2!(z)
282275
return z .= 0.1
@@ -288,7 +281,7 @@ function f3!(z, zz)
288281
return @.. broadcast = false z = zz
289282
end
290283
f3!(z, zz)
291-
@test z == VectorOfArray([fill(4, SVector{2, Float64}), fill(2, SVector{2, Float64})])
284+
@test z == VA[fill(4, SVector{2, Float64}), fill(2, SVector{2, Float64})]
292285
@test (@allocated f3!(z, zz)) == 0
293286

294287
struct ImmutableVectorOfArray{T, N, A} <: AbstractVectorOfArray{T, N, A}
@@ -329,7 +322,7 @@ end
329322
using SparseArrays
330323

331324
# Test that issparse returns false for VectorOfArray
332-
testva = VectorOfArray([[1, 2, 3], [4, 5, 6], [7, 8, 9]])
325+
testva = VA[[1, 2, 3], [4, 5, 6], [7, 8, 9]]
333326
@test issparse(testva) == false
334327

335328
# Test that issparse returns false for DiffEqArray
@@ -342,6 +335,6 @@ end
342335
@test issparse(testview) == false
343336

344337
# Test with nested VectorOfArray
345-
nested_voa = VectorOfArray([testva, testva])
338+
nested_voa = VA[testva, testva]
346339
@test issparse(nested_voa) == false
347340
end

test/linalg.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,4 +56,4 @@ mat = Array(va)
5656
@test all(va'[i] == mat'[i] for i in eachindex(mat'))
5757
@test Array(va') == mat'
5858

59-
@test !ArrayInterface.issingular(VectorOfArray([rand(2), rand(2)]))
59+
@test !ArrayInterface.issingular(VA[rand(2), rand(2)])
Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
using Test, RecursiveArrayTools, StaticArrays
22

3-
p = ArrayPartition(
4-
(
5-
zeros(Float32, 2), zeros(SMatrix{2, 2, Int64}, 2),
6-
zeros(SVector{3, Float64}, 2),
7-
)
8-
)
3+
p = AP[
4+
zeros(Float32, 2),
5+
zeros(SMatrix{2, 2, Int64}, 2),
6+
zeros(SVector{3, Float64}, 2),
7+
]
98
@test eltype(p) == Float64
109
@test recursive_bottom_eltype(p) == Float64
1110
@test recursive_unitless_eltype(p) == Float64
@@ -14,5 +13,5 @@ p = ArrayPartition(
1413
p2 = similar(p)
1514
@test typeof(p2) == typeof(p)
1615

17-
p3 = ArrayPartition(SA[1.0, 2.0], MMatrix{2, 2}([3.0 4.0; 3.0 5.0]))
16+
p3 = AP[SA[1.0, 2.0], MMatrix{2, 2}([3.0 4.0; 3.0 5.0])]
1817
@test (@inferred length(typeof(p3))) == 6

0 commit comments

Comments
 (0)