Commit 51faba4
committed
Fix downstream test breakages exposed by OrdinaryDiffEq 7 bump
The compat bump in the previous commit gets `activate_downstream_env`
past `Pkg.develop`, but the downstream test sources still don't run
because the OrdinaryDiffEq 7 resolution was previously masking three
issues:
- `Rosenbrock23(autodiff = false)` is no longer supported; OrdinaryDiffEq 7
rejects the `Bool` form and asks for an `ADType`. Use `AutoFiniteDiff()`
(already reachable through `using OrdinaryDiffEq`).
- `Rodas5` is no longer re-exported from `OrdinaryDiffEq`; pull it in
via `using OrdinaryDiffEqRosenbrock` and add the package as a dep.
- `AP[...]` shorthand requires `RecursiveArrayToolsShorthandConstructors`
in scope; runtests.jl `Pkg.develop`s the package but never `using`-s it,
so the downstream test files silently never had it.
- `SciMLBase.successful_retcode(...)` requires `SciMLBase` as a bare
binding, which `using OrdinaryDiffEq` doesn't provide. Switch to the
unqualified `successful_retcode` (also already exported through
OrdinaryDiffEq), avoiding the need to add SciMLBase as a direct dep.
Verified locally that the ODE Solve / Events / Measurements and Units /
TrackerExt safetestsets all run to completion after the fix.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>1 parent af4895e commit 51faba4
3 files changed
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| |||
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| 23 | + | |
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
12 | | - | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
75 | | - | |
| 76 | + | |
0 commit comments