Commit 65a3b35
Run CI with JULIA_NUM_THREADS=2 so threaded VoA{SArray} test covers #570
The regression test added in #564 for `@.. thread=true` on
`VectorOfArray{SArray}` only triggers the bug path when
`Threads.nthreads() >= 2`. FastBroadcast's Polyester-backed threaded
materialize splits work along the last axis via `view(dst, :, r)`; with
a single thread that split is a no-op, so the `setindex!` loop that
originally blew up on the immutable `SVector` element in issue #570 is
never reached. CI was delegating to SciML/.github's reusable tests
workflow with no thread configuration, meaning `Threads.nthreads() == 1`
in CI and the regression test was silently passing without actually
exercising the regression.
Inline the previously-reusable test job and set `JULIA_NUM_THREADS: "2"`
on the `julia-actions/julia-runtest` step, mirroring SciML/OrdinaryDiffEq.jl's
SublibraryCI.yml. No changes to the test file are needed.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 110f2aa commit 65a3b35
1 file changed
+33
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
22 | 26 | | |
23 | 27 | | |
24 | 28 | | |
| |||
36 | 40 | | |
37 | 41 | | |
38 | 42 | | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
0 commit comments